search

oddbird / accoutrement

Combined Sass Accoutrement tools, with option for individual module imports
MIT License
37 stars 6 forks source link

Fixed inline function adjustments #118

Closed justin-duncan closed 2 years ago

justin-duncan commented 2 years ago

Updated _resolve-value function to call compile-token in list iterations rather than another _resolve-value to handle case scenarios where a value / do pair is provided.

Bug Described in https://github.com/oddbird/accoutrement/issues/117.

mirisuzanne commented 2 years ago

Thanks @justin-duncan! Do you mind adding a test for this as well? Or paste some code that fails currently (without the change), and we can write a test around it?

justin-duncan commented 2 years ago

Hey @mirisuzanne, apologies for not adding a test. I committed a new test to demonstrate the issue at hand. Hopefully this gives a better understanding of what my change fixes. Hope this helps 😄

mirisuzanne commented 2 years ago

looks good! For some reason GH doesn't run all the checks on external PRs, so I'm pulling it in through a local branch, where we can lint etc, but I think it's all working. Thanks!