search

oddbird / accoutrement

Combined Sass Accoutrement tools, with option for individual module imports
MIT License
37 stars 6 forks source link

Enhancement to tint and shade to use contrast-light and -dark #16

Closed joelschou closed 6 years ago

joelschou commented 6 years ago

This might be going a little overboard, but it seems that if contrast() and contrasted() are going to automatically pull contrast-light and contrast-dark, we should let tint() and shade() do the same.

I considered adding a third argument to tint/shade for $base, just in case the developer wants to tint or shade with colors other than contrast-light and -dark. At that point, dropping down to mix() seems best?

P.S. I don't know why those .html files have all the extra line breaks in them. Sorry.

joelschou commented 6 years ago

Added issue #17

mirisuzanne commented 6 years ago

This also needs a conflict resolved - but otherwise looks great, and ready to go. Changing the base branch to two until we're ready to release a 2.0 (probably soon with these new features - but may be nice to release the bugfix PR as a patch first).

joelschou commented 6 years ago

Welp. The conflict is resolved, but I seem to have sucked in the parsing bugfix (#19). Not sure if that's OK or not.

mirisuzanne commented 6 years ago

Hi, sorry I'm slow getting back to these. I had surgery, but I'm slowly getting back on the computer. Thanks for your patience, while I get my bearings back!

mirisuzanne commented 6 years ago

@joelschou That parsing fix was lovely. I just made a few code-formatting changes to match everything else – which should really be handled by a linter, or at least documented in a code style guide. That's my mistake, not yours. The logic remains the same as you wrote it.

This one also looks great. I'll clean up some final conflicts I caused, and get it merged in. Thanks!

mirisuzanne commented 6 years ago

Moved to #23 for final cleanup, with history intact…