search

oddbird / accoutrement

Combined Sass Accoutrement tools, with option for individual module imports
MIT License
37 stars 6 forks source link

Updated get-token() to use map-has-key() #39

Closed james-camilleri closed 5 years ago

james-camilleri commented 5 years ago

This allows for maps to contain falsey values, since we are no longer relying on the null thrown by map-get() to determine if a key exists.

mirisuzanne commented 5 years ago

Thanks! It doesn't look like the tests are failing - something specific to a node version. I'll download this and run it against one of our other projects just to be sure it's backwards compatible before we merge and release.

james-camilleri commented 5 years ago

I ran all the tests before pushing, seemed fine on my end. There are a couple of lint issues in a another file though, and there was an error creating the styles for the docs which I don't believe is related.

jgerigmeyer commented 5 years ago

Already merged in #37.