search

oddbird / accoutrement

Combined Sass Accoutrement tools, with option for individual module imports
MIT License
37 stars 6 forks source link

Fix bug:missing submap key, add dart tests #60

Closed johncrim closed 3 years ago

johncrim commented 3 years ago

Issue described here: https://github.com/oddbird/accoutrement/issues/49

This is still an issue with dart-sass when $handle-missing-keys is not set. PR includes a test case for this, which failed with previous code on dart-sass only.

PR also adds most of the existing tests to run in dart-sass. There is more work to do to make all tests run in dart-sass, but that is outside the scope of this issue.

johncrim commented 3 years ago

Sure, I'll update the changelog (@mirisuzanne - assuming you're asking me to do it). I don't know about the release process, let me know if that's a request for me (and I'll need docs on the process) or someone else.

johncrim commented 3 years ago

I'm going to hold off on updating the changelog until I hear whether you want me to do it, or a maintainer (@jgerigmeyer ?). I'm happy to help out, but don't want to step on anyone's toes.

mirisuzanne commented 3 years ago

@johncrim Go for it. You can add a new block at the top of the markdown file, with UNRELEASED instead of a version number and date. Then follow the pattern established there – a list-item describing the change, prefixed with e.g. BREAKING, the relevant (#issue). Does that make sense?

johncrim commented 3 years ago

Changelog has been updated. My other PR (#62) builds on top of this one, b/c it needs the dart tests. So please merge this one first.

mirisuzanne commented 3 years ago

Thanks @johncrim !