Modules type

[dvdherron]

Description

Upgrading the type module with Sass module usage.

Steps to test/reproduce

See files in ./sass/type/

Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).

Show me

Provide screenshots/animated gifs/videos if necessary.

[dvdherron]

I want Accoutrement on Sass Modules

[mirisuzanne]

I want Accoutrement on Sass Modules

[dvdherron]

@mirisuzanne I'm working through updating this module and fixing the tests.

Tests are passing for config, a11y, and pseudo-elements. I still need to work on font-vars, fonts and helpers.

Three tests are failing in normalize. (I've commented them out). Can you tell if there's something wrong in the tests or in type/normalize that's causing them to fail?

[dvdherron]

@mirisuzanne @stacyk

I cleaned up based on the review:

• made normalize and helper private
• renamed the functions in normalize so that they would not be double referenced.
• and fixed the missing module references

It seems like I'm missing loading a module somewhere though. When I remove the type files from the IGNORE_SASS list in the gulpfile, I get errors about undefined mixins and variables in the examples:

» [WARNING] Error compiling @example scss: 
Undefined mixin.
   ╷
3  │ ┌ @include tools.import-font-face(
4  │ │   $name: 'Franklin Gothic',
5  │ │   $weight: 'normal',
6  │ │   $style: 'normal',
7  │ │   $data: (
8  │ │     'local': 'Franklin Gothic' ('franklin-gothic'),
9  │ │     'woff2': 'path/to/franklin-bolditalic-font.woff2',
10 │ │     'ttf': 'path/to/franklin-bolditalic-font.ttf',
11 │ │   )
12 │ │ );

│ └─^

I'll take a closer look at what's happening here tomorrow.