search

oddlama / vane

Immersive and lore friendly enhancements for vanilla Minecraft
MIT License
276 stars 34 forks source link

Investigate using xaero's minimap waypoints #138

Open ryantheleach opened 2 years ago

ryantheleach commented 2 years ago

It would be really nice if vane also supported xaero's minimap waypoints in addition to bluemap/dynmap/squremap

https://www.spigotmc.org/resources/minimapapi.35354/

Not sure if that library is published or safe, need to do some investigation.

Could also potentially tie into portal discover feature we discussed, since these waypoints are trivial to implement per player.

MagnusHJensen commented 2 years ago

To add on to this, to speak on the validity of the plugin. Even though it's old and released back in 2017 it was co-authored by xaero96, which is the creator of xaero's mm and wm, so It's safe to use, but it would be nice to just add the code instead of having to rely on a third party lib for something that small.

oddlama commented 2 years ago

I'm not at all opposed to adding this! Sounds like a perfectly reasonable addition! Usually, I just add the features I need for my own needs, which is why this has been kind of stale. So I'd be super happy if anyone would create a PR for this! :D

Serial-ATA commented 2 years ago

I tried this out, and the plugin tries to register an invalid channel name. Looks like the requirements changed in 1.13. Given the plugin and mod are closed source, I don't think this is possible.

oddlama commented 2 years ago

Ah that's too bad, I guess I'll close this then. Thanks for checking.

Serial-ATA commented 2 years ago

Spoke to xaero96 about this, and they plan on making a new API for this in the future. Don't know when as of now.