oddlama / vane

Immersive and lore friendly enhancements for vanilla Minecraft
MIT License
276 stars 34 forks source link

North compass showing random locations #198

Closed WaxenSs closed 2 months ago

WaxenSs commented 1 year ago

When the north compass is on one hand, the indication showing random locations

MC Version: 1.20.1 Paper Version: 1.20.1-18

I tried to :

WaxenSs commented 1 year ago

Ok I just unintentionally drop the compass, and from the moment I got it back, it started working normally, strange 🤔 And that's not all, now when I craft another north compass, the problem is gone. Throwing the compass away and picking it up again fixes the bug 🤯

oddlama commented 1 year ago

Yeah the north compass requires some hacky tricks and thus can get a little weird. The issue is that minecraft doesn't support a north compass per-se, so we set a location in the current world that is at 0,-999999999 (very far north) so for all practical purposes it will be north.

If you change world etc, this location needs to be updated, and we are doing that by resetting the location on certain events. So picking it up fixes it :P What's more interesting is why it needs fixing after crafting, since that was working in 1.19 🤔

WaxenSs commented 1 year ago

Yes, it is strange.. But now, my compass is working perfectly!

oddlama commented 1 year ago

I'll see if I can reproduce this somehow, maybe something weird changed between versions that I'm not aware of. Ideally it shouldn't need to be dropped to start working 😅

TDuffinNTU commented 1 year ago

FWIW I ran into this issue when giving myself the item with commands/creative, but in survival I crafted it and it worked fine. Could be that commands/creative don't give the correct compass for the dimension you're in!