search

oddlama / vane

Immersive and lore friendly enhancements for vanilla Minecraft
MIT License
276 stars 34 forks source link

Disable Loot Protection of vane-core #34

Closed Zoriot closed 3 years ago

Zoriot commented 3 years ago

Please add an Config option to disable the loot Protection of vane-core it sucks :(

oddlama commented 3 years ago

I'm sure I can add that option in the next update, and I'm also sorry that you think it sucks.

It sounds like you have a strong opinion on the matter, so I'd be glad if you can elaborate on why you think that way, so that I can improve the feature.

Zoriot commented 3 years ago

Sorry i was a bit tired when I wrote the issue, yesterday we went to the end and we forget chests to make shulker chests, so we need the chests in end cities. I know the general aspect of the protection but for such a big think, there should be an config.

Also, In my Eyes the Configs are not really Straight Forward and there should be a Wiki for it.

Thank you for implementing this!

oddlama commented 3 years ago

No worries. Although I'm not 100% sure we are talking about the same thing, as vane's loot chest protection doesn't simply make loot chests unbreakable. You can still destroy them as usual, you just need to break it twice in a row in short succession (5 seconds or something). Although I noticed that the message is actually wrong here, so maybe thats where the confusion comes from.

PaperMC has an optional setting to refill loot after some real-life days, which is quite nice for medium sized servers where several people might find the chests regularly. When people break the chests they can't be refilled and it might be frustrating to a lot of players finding looted structures all the time. Therefore I added this feature to have people reconsider breaking loot chests.

I also noticed that the message is in fact wrong if papers refill feature hasn't been activated. So that's something I should also change. When I do this I can of course add a config to disable the feature altogether.

What part of the config isn't straightforward to you? My ambition was to create a self contained config that describes itself and every config option thoroughly. Do let me know what you find confusing so that I can improve it. Also if you think anything (else) is ambiguous or misleading, definitely create an issue for it.