search

oddlama / vane

Immersive and lore friendly enhancements for vanilla Minecraft
MIT License
276 stars 34 forks source link

vane-permission default not working #49

Closed Pumamori closed 3 years ago

Pumamori commented 3 years ago

This might be an user error, feel free to close if it is, but it's behaving so unexpectedly that I figured asking wouldn't hurt.

I'm using everything except for vane-regions and vane-waterfall, in vane-permissions I have set the following:

default_group: "user"
vouch_group: "verified"

user:
    - vane.permissions.groups.default
    - vane.admin.commands.spawn
    - vane.admin.modify_world
verified:
    - vane.permissions.groups.user
    - vane.permissions.commands.vouch

To my knowledge, "vane.admin.modify_world" is the permission needed to actually interact with the world, break blocks and what not, with "user" being the permission group new people should theoretically be added to.

However, the actual behaviour is that when people join, they can't break anything at all until they're vouched for. I'm assuming they're still being put in the "default" group, despite the setting in "default_group".

oddlama commented 3 years ago

No, you are absolutely right, thanks for bringing it to my attention - and this is exactly what issues are for.

Your configuration is 100% correct and I have indeed only added the config option but forgot to actually implement the required behavior (oops). I'll fix this when I have more time on my hands in the coming weeks. I hope you can bear with the current behavior a little longer :P

EDIT: A dirty temporary workaround would of course be to just add the permissions from the user group to the default group. It kind of goes against the privilege separation principle, but you wouldn't have to add everyone to the group manually every time.

KingTheGuy commented 3 years ago

im not sure if i have something configured wrong, players aren't auto put into any groups, whether that be "user" or "default".

tofu-7 commented 3 years ago

~woops this shows up when I link it in our server files~

Anyway, I was wondering if there's been any progress on fixing this issue, or is the best course still to use the workaround?

oddlama commented 3 years ago

I'll have time to implement this and some of the other open issues in the coming days, so this will be fixed soon :)