Pressure pop-up not scrolling along with page

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.

https://care.ohc.network

MIT License

258 stars 452 forks source link

Pressure pop-up not scrolling along with page #5088

Closed rithviknishad closed 3 months ago

rithviknishad commented 1 year ago

Describe the bug

[ ] When we open a pressure sore pop-up and scroll, the pop-up doesn't scroll along with it.
[ ] Pop-up does not close when clicked outside

To Reproduce Steps to reproduce the behavior:

Go to a patient's pressure sore tab
Click on any body part.
Scroll / click outside.

Expected behavior

[ ] Pop-up may scroll along with the page.
[ ] Pop-up may close when clicked outside.

Screenshots

github-actions[bot] commented 1 year ago

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

github-actions[bot] commented 1 year ago

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

nikhilagastya commented 1 year ago

hey @khavinshankar can you assign me this issue

nikhilagastya commented 1 year ago

working on it !

Rohanxmalik commented 1 year ago

Are you still working on this @nikhilagastya . If not I want to contribute under C4GT, please assign it to me.

nikhilagastya commented 1 year ago

hey @rithviknishad could u help me with something , Here to remove the modal I need to work on pressure_sore_editor.res file right ? Coz earlier i was working on a .bs file and the changes got removed whenever i was deploying on the localhost .

rithviknishad commented 1 year ago

.bs files are generated files. You need to update the rescript files

nihal467 commented 1 year ago

@nikhilagastya unassigning you from this issue, due to inactivity for almost two months

CC: @rithviknishad

sghosh28 commented 1 year ago

Hey @rithviknishad I hope this message finds you well. I've been diligently working on the project and I'm excited to update you on the progress I've made so far:

[ x] Resolved the issue where the pop-up doesn't close when clicked outside.

With this done, I'm now moving on to tackle the next challenge: addressing the scroll-along-with-page problem. I'm confident I can make headway on this front as well.

Could you kindly assign this task to me?

sghosh28 commented 1 year ago

Hello @rithviknishad ,

I'm pleased to inform you that I've successfully resolved both of the mentioned issues:

[x] The pop-up now remains appropriately positioned as the page is scrolled.
[x] The pop-up is designed to close when clicking outside of it.

Could you kindly review the pull request at your earliest convenience?

Thank you!

sghosh28 commented 1 year ago

Hey @rithviknishad,

I have made new changes, can you please review my pull request? Thank you!

stokedowl commented 5 months ago

@nihal467 Is this still a bug? I cannot seem to reproduce locally. Let me know if it is, I can pick it up.

gigincg commented 3 months ago

@stokedowl This is still an issue, @sghosh28 had attempted to fix the issue, but it seems to have been a little buggy. You could try salvaging the PR or you could make a new PR.

gigincg commented 3 months ago

@stokedowl The PR from @sghosh28 was not salveageable due to a recent refactor from Rescript to Typescript for the applicable files. I made a PR to fix the issue. I'm not an expert at Positioning, so I would appreciate a review.

If you can think of a better solution please do let us know & Feel free to take up any other issues as well.

You can also join in on our slack community at https://slack.ohc.network/ Where you can reach the team for any questions/discussions.