ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
257 stars 443 forks source link

remove lodash #6006

Open sainak opened 1 year ago

github-actions[bot] commented 1 year ago

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

github-actions[bot] commented 1 year ago

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

rithviknishad commented 1 year ago

Keeping the issue opened, as loadash was not removed and only replaced in previous PR

Ashesh3 commented 11 months ago

@sainak are you still working on this?

tellmeY18 commented 2 months ago

@gigincg

bodhish commented 1 month ago

@tellmeY18 Whats the status here?

SwanandBhuskute commented 1 week ago

@rithviknishad @nihal467 pls assign me this issue

SwanandBhuskute commented 1 week ago

@tellmeY18 @nihal467 @rithviknishad so here

and similar in other files

is my approach right?

rithviknishad commented 1 week ago

Yup!

For casing changes specifically, I'd suggest refactoring the usages to use tailwind's text transform classes instead of JS wherever possible.

SwanandBhuskute commented 1 week ago

ok understood @rithviknishad

SwanandBhuskute commented 1 week ago

@rithviknishad @tellmeY18 @nihal467 I have removed all the lodash imports and used custom js functions / properties

but these two files

has too many lodash occurences

so now after uninstalling lodash from the project

how should i handle these two files?

tellmeY18 commented 1 week ago

Hey, the bom.json and fe-sbom.json are autogenerated via a workflow which is listing out the dependencies used in care and care_fe. you can ignore the occurance of lodash inside these 2 files and once it's completely removed from the project we should be able to generate jsons that doesn't have lodash occurences.

SwanandBhuskute commented 1 week ago

Hey, the bom.json and fe-sbom.json are autogenerated via a workflow which is listing out the dependencies used in care and care_fe. you can ignore the occurance of lodash inside these 2 files and once it's completely removed from the project we should be able to generate jsons that doesn't have lodash occurences.

oh okay, then I will just raise PR

SwanandBhuskute commented 1 week ago

@tellmeY18 @rithviknishad @nihal467 hey after running npm run build i got this log

Image