Clean up Facility registration form - Githubissues

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.

https://care.ohc.network

MIT License

205 stars 379 forks source link

Clean up Facility registration form #7758

Open aparnacoronasafe opened 4 months ago

aparnacoronasafe commented 4 months ago

Is your feature request related to a problem? Please describe. Details of oxygen storage and consumption may not be very relevant for many facilities registered in CARE.

Hence the data input fields may be moved to a separate section in the facility dashboard https://care.coronasafe.in/facility/40ff580a-b37f-4738-b74c-25073d6b1288 (like the bed capacity and doctor's list)

Describe the solution you'd like

[ ] Remove the oxygen related fields from facility registration form https://care.coronasafe.in/facility/40ff580a-b37f-4738-b74c-25073d6b1288/update
[ ] On facility dashboard edit the title "Oxygen Information" to "Details on oxygen supply and consumption"
[ ] Add button to "Add details"
[ ] Pop-up to be added (design consistent with "Bed Capacity") Pop-up title "Add oxygen details" with
Type of oxygen (dropdown with "Liquid Oxygen, Type B cylinder, Type C cylinder, Type D cylinder"
Field for Max. Capacity and Expected burn rate to be added on the Pop-up window
[ ] Visualisation of the details to be kept in consistent with the visualisation of bed capacity and doctors list.

609harsh commented 4 months ago

hey @rithviknishad please assign this issue to me.

609harsh commented 4 months ago

@rithviknishad for oxygen do we have any icon already at add oxygen details button?

rithviknishad commented 4 months ago

Couldn't find one specific to oxygen/cylinder. You could use the same one as the one used in the "Add Triage" button.

609harsh commented 4 months ago

Hi @rithviknishad, we need 4 new api endpoints (Get,Post,Put,Delete) for Oxygen Section at facility home page. can i create those or do i have to raise a issue?

Also while making Post api call at update facility button should we remove oxygen data that we are sending (as in ui we have removed) or keep default values to be 0. since if we remove oxygen related data for api call i guess we will also need to update that endpoint.

rithviknishad commented 4 months ago

You could simply use the existing PATCH facility api instead right?

609harsh commented 4 months ago

@rithviknishad this one?

rithviknishad commented 4 months ago

Yup!

609harsh commented 4 months ago

and what about fetching oxygen details? should i use this

rithviknishad commented 4 months ago

You don't need to fetch anything right? The parent component which is the facility details page, already would have fetched the facility record right? Just pass it down as a prop?