search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
204 stars 375 forks source link

Hide sensitive user data for non admin users #8458

Open khavinshankar opened 2 weeks ago

khavinshankar commented 2 weeks ago

Proposed Changes

Depends on: https://github.com/ohcnetwork/care/pull/2222

@ohcnetwork/care-fe-code-reviewers

netlify[bot] commented 2 weeks ago

Deploy Preview for care-ohc failed.

Name Link
Latest commit 0a61c3f5018a9c1415820ecca5155c0042fa3a54
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e9267db4da440008728908
nihal467 commented 2 weeks ago

Functionality looks good, fix the cypress failure

github-actions[bot] commented 2 weeks ago

:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

cypress[bot] commented 2 days ago

CARE    Run #3367

Run Properties:  status check failed Failed #3367  •  git commit 0a61c3f501: Hide sensitive user data for non admin users
Project CARE
Branch Review fixes#7374
Run status status check failed Failed #3367
Run duration 03m 19s
Commit git commit 0a61c3f501: Hide sensitive user data for non admin users
Committer Khavin Shankar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 122
View all changes introduced in this branch ↗︎

Tests for review

Failed  user_manage.cy.ts • 2 failed tests • UI-Chrome View Output
Test Artifacts
Manage User > add working hour for a user and verify its reflection in card and user profile Test Replay Screenshots
Manage User > linking and unlinking facility for multiple users, and confirm reflection in user cards and doctor connect Test Replay Screenshots
Failed  UsersManage.cy.ts • 2 failed tests • UI-Chrome View Output
Test Artifacts
Manage User > add working hour for a user and verify its reflection in card and user profile Test Replay Screenshots
Manage User > linking and unlinking facility for multiple users, and confirm reflection in user cards and doctor connect Test Replay Screenshots
github-actions[bot] commented 21 hours ago

:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.