ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
204 stars 373 forks source link

Updated blood pressure range #8498

Open rithviknishad opened 1 week ago

rithviknishad commented 1 week ago

Required Backends

Proposed Changes

image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

netlify[bot] commented 1 week ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 585b645d350b2b5a5c7c8497801917baf1089183
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e51ce5e5c0d50008aeef9c
Deploy Preview https://deploy-preview-8498--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 1 week ago

CARE    Run #3344

Run Properties:  status check passed Passed #3344  •  git commit 585b645d35: Updated blood pressure range
Project CARE
Branch Review rithviknishad/fix/blood-pressure-range-and-recordable
Run status status check passed Passed #3344
Run duration 02m 58s
Commit git commit 585b645d35: Updated blood pressure range
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 128
View all changes introduced in this branch ↗︎
bodhish commented 1 week ago

@rithviknishad the ux assumes that not measurable is a very common scenario; do we need it? How valuable is not measurable information? Can't that be part of the notes?

CC: @gigincg @aparnacoronasafe

aparnacoronasafe commented 1 week ago

The layout of the short vitals form (with text box and not slider) looks very bad.

Can we have "Not measurable" come below the text field?

The text spaces for systolic and diastolic must come together as "__/___"- having the checkbox come in between the field is not ideal.

aparnacoronasafe commented 1 week ago

@rithviknishad the ux assumes that not measurable is a very common scenario; do we need it? How valuable is not measurable information? Can't that be part of the notes?

CC: @gigincg @aparnacoronasafe

"Not measurable" is not a very common scenario. design to be improved to have the option come up below BP fields, not above

github-actions[bot] commented 1 week ago

:wave: Hi, @rithviknishad, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

nihal467 commented 4 days ago

@rithviknishad image

nihal467 commented 1 day ago

LGTM