Open rithviknishad opened 1 week ago
Name | Link |
---|---|
Latest commit | 585b645d350b2b5a5c7c8497801917baf1089183 |
Latest deploy log | https://app.netlify.com/sites/care-ohc/deploys/66e51ce5e5c0d50008aeef9c |
Deploy Preview | https://deploy-preview-8498--care-ohc.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Passed #3344
•
585b645d35: Updated blood pressure range
Project |
CARE
|
Branch Review |
rithviknishad/fix/blood-pressure-range-and-recordable
|
Run status |
Passed #3344
|
Run duration | 02m 58s |
Commit |
585b645d35: Updated blood pressure range
|
Committer | Rithvik Nishad |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
128
|
View all changes introduced in this branch ↗︎ |
@rithviknishad the ux assumes that not measurable is a very common scenario; do we need it? How valuable is not measurable information? Can't that be part of the notes?
CC: @gigincg @aparnacoronasafe
The layout of the short vitals form (with text box and not slider) looks very bad.
Can we have "Not measurable" come below the text field?
The text spaces for systolic and diastolic must come together as "__/___"- having the checkbox come in between the field is not ideal.
@rithviknishad the ux assumes that not measurable is a very common scenario; do we need it? How valuable is not measurable information? Can't that be part of the notes?
CC: @gigincg @aparnacoronasafe
"Not measurable" is not a very common scenario. design to be improved to have the option come up below BP fields, not above
:wave: Hi, @rithviknishad, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@rithviknishad
LGTM
Required Backends
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist