search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
242 stars 426 forks source link

Add cache-control header for index.html #8516

Closed sainak closed 1 month ago

sainak commented 1 month ago

In the nginx conf there are no cache control headers added which causes the index.html to be cached by the browser

to fix this add a cache-control header with ttl = 7 days for regular files and ttl = 6 hrs for index.html

AdityaJ2305 commented 1 month ago

Hi @sainak I would like to work on this feature. Could you assign it to me ?

AdityaJ2305 commented 1 month ago

Work In Progress

AdityaJ2305 commented 1 month ago

@sainak I see the backend sets Cache-Control: max-age=31536000, immutable. Should I use proxy_hide_header to change this, or is it intentional?

Screenshot 2024-09-12 at 12 16 37 PM
AdityaJ2305 commented 1 month ago

@sainak Should I make the PR with proxy_hide_header ?

vishwansh01 commented 1 month ago

Hi @sainak ! I just created a pull request solving this issue : #8575

AdityaJ2305 commented 1 month ago

Hi @sainak @rithviknishad , I was working on this issue and had a few questions, but noticed @vishwansh01 submitted a PR without being assigned. Could you clarify how to proceed in such cases? Thanks!