search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
204 stars 373 forks source link

Consistency in label prop name for `RadioFormField` #8529

Open rithviknishad opened 5 days ago

rithviknishad commented 5 days ago

The RadioFormField component uses optionDisplay prop to render the label. However, all other CareUI components such as SelectFormField, MultiSelectFormField, AutocompleteFormField, 'AutocompleteMultiselectFormField, etc. usesoptionLabel` as the prop name to for the field label.

Hence for improving consistency, let's rename the optionDisplay to optionLabel for the RadioFormField component.

Screenshots

Usages of optionLabel (185 results)

image

Usages of optionDisplay (28 results) that needs to be replaced with optionLabel

image
xakep8 commented 5 days ago

I would like to work on this issue could you assign this to me?