ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
255 stars 441 forks source link

Software Update notification badges are overlapping #9039

Open samholics opened 2 weeks ago

samholics commented 2 weeks ago

Describe the bug when trying to update software by clicking " check for update" option on profile page, Updated successfully notification comes up even before clicking on update button on the "software update is available" notification. These two overlap each other

Image

link for the video: https://drive.google.com/file/d/1Df4rkPPWFk8yhRX2ddTpln6SmPIwfa8u/view?usp=sharing

To Reproduce Steps to reproduce the behavior:

  1. Go to profile
  2. Click on '' check for update'
  3. See error

Expected behavior

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

ayushpatil2122 commented 2 weeks ago

hey can you assign this issue to me

SwanandBhuskute commented 2 weeks ago

I would like to work on this issue, pls assign me @samholics

bodhish commented 1 week ago

@ayushpatil2122 if you are working on this issue please create a draft PR

ANIR1604 commented 1 week ago

I would like work on this, if that's okay.

ANIR1604 commented 1 week ago

@rithviknishad On running the website through - npm run dev, when i go for check of updates its keeps on loading.

rithviknishad commented 1 week ago

https://github.com/ohcnetwork/care_fe/blob/develop/package.json#L36

You might want to try building and running instead.

ANIR1604 commented 6 days ago

@rithviknishad Please check the PR, I had resolved the issue of the notifications overlapping each other.

ANIR1604 commented 5 days ago

@rithviknishad I had solved this issue by aligning the processes one by one but its giving error in cypress tests in the file which was not edited or changed by me. I am a new contributor in you org can you please guide.

Jacobjeevan commented 1 hour ago

@ANIR1604 Since you deleted the branch, are you still working on this?

If so, you would need to continue on the same branch.