Update Resource Forms to Enhance Validation

JavidSumra commented 2 weeks ago

Proposed Changes

Fixes #9053
Prevents negative values in the Required Quantity field during resource updates.
Enforces a non-empty Description field as mandatory for updates.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

[x] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation (if applicable).
[x] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[x] Request for Peer Reviews
[ ] Completion of QA

Summary by CodeRabbit

New Features
- Enhanced input validation for requested_quantity and assigned_quantity fields to accept only numeric values with a minimum of 1.
- Added required fields for title and reason in the resource form, ensuring all necessary information is provided before submission.
Bug Fixes
- Improved error handling and validation logic for form submissions, ensuring accurate feedback for users.
Tests
- Updated test cases to enhance functionality, specifically for selecting options in the resource status update process.

netlify[bot] commented 2 weeks ago

Deploy Preview for care-ohc ready!

Name	Link
Latest commit	2c98d0249305f4769ff3a35cdabc0d810b114181
Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/674093b76a6161000889f879
Deploy Preview	https://deploy-preview-9062--care-ohc.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes involve updates to several components related to resource management. The ResourceCreate component now includes a utility function for sanitizing numeric input, enforcing numeric constraints on the requested_quantity field. The ResourceDetailsUpdate component has enhanced validation logic and error handling, particularly for new required fields. Additionally, a Cypress test file has been modified to improve test coverage for resource updates. A new utility function, sanitizeNumberInput, has also been introduced to ensure only numeric values are accepted in input fields.

Changes

File	Change Summary
`src/components/Resource/ResourceCreate.tsx`	- Added `sanitizeNumberInput` utility function. - Modified `TextFormField` for `requested_quantity` to enforce numeric input (type="number", min={1}). - Updated `onInput` event to call `sanitizeNumberInput`.
`src/components/Resource/ResourceDetailsUpdate.tsx`	- Updated validation logic by replacing `assigned_facility_type` with `assigned_facility_object`. - Added required fields `title` and `reason` with error messages. - Enhanced form submission logic to check for valid form state.
`cypress/e2e/resource_spec/ResourcesHomepage.cy.ts`	- Adjusted import statements and added functionality to select an option from `assigned_facility_object` in tests.
`src/Utils/utils.ts`	- Introduced `sanitizeNumberInput` function to sanitize numeric input in forms.

Assessment against linked issues

Objective	Addressed	Explanation
Required Quantity should not accept negative values (9053)	✅
Description field should be mandatory (9053)	❌	No changes were made to enforce description field validation.

Possibly related PRs

#8940: This PR modifies the TextFormField for requested_quantity to include the onInput event referencing sanitizeNumberInput, which is directly related to the changes made in the main PR regarding the same field.
#9096: The changes in this PR involve updates to the List View layout in the Resources section, which includes the ResourceCreate component. This is relevant as the main PR also pertains to the ResourceCreate component, indicating a connection in the context of resource management.

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad
shivankacker
Jacobjeevan

🐇 In the fields where bunnies play,
Numbers hop and dance all day.
With inputs clean and errors few,
Resource updates, fresh and new!
So let’s rejoice, for changes bright,
Our forms are now a pure delight! 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

nihal467 commented 2 weeks ago

[ ] the PR is not solving the issue @JavidSumra

JavidSumra commented 2 weeks ago

Have you updated the value or is it already present there? cc @nihal467

nihal467 commented 1 week ago

@JavidSumra i updated the value

nihal467 commented 10 hours ago

[ ] We can create a new resource request with a required quantity of 0. However, after creation, when we open the update resource page, a validation error is thrown. If the value is restricted, the error should be thrown during creation itself.

ohcnetwork / care_fe