Closed JavidSumra closed 2 weeks ago
[!CAUTION]
Review failed
The pull request is closed.
The changes involve updates to the package.json
and scripts/sort-locales.js
files. The package.json
file has modified the lint-staged
configuration to point to a new directory for JSON locale files and added a packageManager
field specifying the use of npm@10.9.0
. The scripts/sort-locales.js
file has also been updated to reflect the new path for reading and writing locale data, moving from the src
directory to the public
directory. Additionally, several Cypress test files have undergone reordering of import statements, but their core functionality remains unchanged.
File | Change Summary |
---|---|
package.json | Updated lint-staged path from "src/Locale/*.json" to "public/locale/*.json" . Added packageManager field with value "npm@10.9.0" . Modified format script to include ./cypress . |
scripts/sort-locales.js | Changed file path for reading and writing locale data from "src/Locale/en.json" to "public/locale/en.json" . |
cypress/e2e/facility_spec/FacilityLocation.cy.ts | Reordered import statements, added uuid import. |
cypress/e2e/users_spec/UsersProfile.cy.ts | Reordered import statement for UserProfilePage . |
cypress/pageobject/Patient/PatientPredefined.ts | Reintroduced PatientPage import and included generatePhoneNumber function in imports. |
cypress/tsconfig.json | Reformatted lib array for readability and added a newline at the end of the file. |
sequenceDiagram
participant User
participant Lint
participant Sorter
User->>Lint: Trigger lint-staged
Lint->>Sorter: Read locale data from public/locale/en.json
Sorter->>Sorter: Sort JSON data
Sorter->>Lint: Write sorted data back to public/locale/en.json
🐇 "In the public glade, the locales now play,
With paths all anew, they hop and they sway.
From src they have leapt, to the public they go,
Sorting their keys in a neat little row.
With npm in hand, we dance through the day,
Hooray for the changes, hip-hip-hooray!" 🥳
lint-staged
configuration and the locale file paths in both package.json
and scripts/sort-locales.js
, mirroring the changes made in the main PR.needs testing
, needs review
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Name | Link |
---|---|
Latest commit | 2754732fbd87b27df080b05765db543c9ddab992 |
Latest deploy log | https://app.netlify.com/sites/care-ohc/deploys/672ef5de37886500084c97e2 |
Deploy Preview | https://deploy-preview-9070--care-ohc.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey @rithviknishad can you please review the changes?
@JavidSumra @JavidSumra Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
Bug Fixes