ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
257 stars 443 forks source link

fix locale sort's path and fix format script to sort cypress dir #9070

Closed JavidSumra closed 2 weeks ago

JavidSumra commented 2 weeks ago

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes involve updates to the package.json and scripts/sort-locales.js files. The package.json file has modified the lint-staged configuration to point to a new directory for JSON locale files and added a packageManager field specifying the use of npm@10.9.0. The scripts/sort-locales.js file has also been updated to reflect the new path for reading and writing locale data, moving from the src directory to the public directory. Additionally, several Cypress test files have undergone reordering of import statements, but their core functionality remains unchanged.

Changes

File Change Summary
package.json Updated lint-staged path from "src/Locale/*.json" to "public/locale/*.json". Added packageManager field with value "npm@10.9.0". Modified format script to include ./cypress.
scripts/sort-locales.js Changed file path for reading and writing locale data from "src/Locale/en.json" to "public/locale/en.json".
cypress/e2e/facility_spec/FacilityLocation.cy.ts Reordered import statements, added uuid import.
cypress/e2e/users_spec/UsersProfile.cy.ts Reordered import statement for UserProfilePage.
cypress/pageobject/Patient/PatientPredefined.ts Reintroduced PatientPage import and included generatePhoneNumber function in imports.
cypress/tsconfig.json Reformatted lib array for readability and added a newline at the end of the file.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Lint
    participant Sorter

    User->>Lint: Trigger lint-staged
    Lint->>Sorter: Read locale data from public/locale/en.json
    Sorter->>Sorter: Sort JSON data
    Sorter->>Lint: Write sorted data back to public/locale/en.json

🐇 "In the public glade, the locales now play,
With paths all anew, they hop and they sway.
From src they have leapt, to the public they go,
Sorting their keys in a neat little row.
With npm in hand, we dance through the day,
Hooray for the changes, hip-hip-hooray!" 🥳

Possibly related PRs

Suggested labels

needs testing, needs review

Suggested reviewers


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 weeks ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 2754732fbd87b27df080b05765db543c9ddab992
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/672ef5de37886500084c97e2
Deploy Preview https://deploy-preview-9070--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JavidSumra commented 2 weeks ago

Hey @rithviknishad can you please review the changes?

github-actions[bot] commented 2 weeks ago

@JavidSumra @JavidSumra Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: