search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
257 stars 443 forks source link

Enhancements to the nursing care procedures and routines tables #9079

Closed sainak closed 6 days ago

sainak commented 2 weeks ago

Picked up changes from https://github.com/ohcnetwork/care_fe/pull/8608

Changes made fixes: https://github.com/ohcnetwork/care_fe/issues/8562

  1. Added a reusable component.
  2. fixed width of the 2nd column onwards

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces significant updates to the ConsultationNursingTab component, including the addition of a new NursingPlot component for asynchronous data fetching and improved data display. The existing table structure has been replaced with a new LogUpdateAnalyseTable component for rendering routine analysis results. Additionally, the type definition for NursingPlotRes has been refined for better type safety. The changes streamline the component's architecture and enhance the overall data handling and presentation.

Changes

File Path Change Summary
src/components/Facility/ConsultationDetails/ConsultationNursingTab.tsx Introduced NursingPlot for data fetching, updated ConsultationNursingTab to use NursingPlot, and modified RoutineSection to utilize LogUpdateAnalyseTable.
src/components/Facility/Consultations/NursingPlot.tsx Deleted the previous NursingPlot component.
src/components/Facility/models.tsx Updated NursingPlotRes type definition to enforce a structured array for the nursing property.
src/components/Facility/Consultations/LogUpdateAnalyseTable.tsx Added LogUpdateAnalyseTable component for rendering a dynamic table with internationalization support.

Assessment against linked issues

Objective Addressed Explanation
Make the Nursing Care section similar to the Routine Section by switching to a table layout (#8562) ✅
Lock the first row of the field name in routine section table (#8562) ❌ This feature was not implemented.
Have fixed width for time columns (#8562) ❌ This feature was not implemented.
Improve overall UI (borders or colors, etc.) (#8562) ❓ UI improvements are not explicitly detailed.

Possibly related PRs

Suggested labels

changes required

Suggested reviewers

Poem

🐰 In the Nursing Tab, we now fetch with ease,
New components added, as smooth as a breeze.
Data displayed in a table so neat,
With every log update, our work is complete!
Hopping along, we improve and refine,
For better care, our code will shine! ✨

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
src/components/Facility/ConsultationDetails/ConsultationNursingTab.tsx Oops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.json': Cannot find module '@typescript-eslint/parser' Require stack: - /.eslintrc.json at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15) at Function.resolve (node:internal/modules/helpers:145:19) at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46) at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28) at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 weeks ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 1cabe0a21b47150e17a1cba12e0954c0cbed46ed
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67349961cf222c0008fb6c17
Deploy Preview https://deploy-preview-9079--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 2 weeks ago

CARE    Run #3904

Run Properties:  status check passed Passed #3904  •  git commit 1cabe0a21b: Enhancements to the nursing care procedures and routines tables
Project CARE
Branch Review issues/8562/Nursing_tab_ui
Run status status check passed Passed #3904
Run duration 04m 52s
Commit git commit 1cabe0a21b: Enhancements to the nursing care procedures and routines tables
Committer Aakash Singh
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎
cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cabe0a
Status: ✅  Deploy successful!
Preview URL: https://b7314b95.care-fe.pages.dev
Branch Preview URL: https://issues-8562-nursing-tab-ui.care-fe.pages.dev

View logs

sainak commented 2 weeks ago

@coderabbitai full review

coderabbitai[bot] commented 2 weeks ago
:white_check_mark: Actions performed Full review triggered.
sainak commented 2 weeks ago

@coderabbitai full review

coderabbitai[bot] commented 2 weeks ago
:white_check_mark: Actions performed Full review triggered.
nihal467 commented 6 days ago

LGTM

github-actions[bot] commented 6 days ago

@sainak @sainak Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: