search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
257 stars 443 forks source link

Fix wrong terminology used in place of Log Update #9089

Closed yash-learner closed 1 week ago

yash-learner commented 2 weeks ago

Proposed Changes

Things to check:

This pull request includes significant updates to the application's routing and terminology, specifically changing references from "daily rounds" to "log updates". The changes span multiple files and components, ensuring consistency across the codebase.

Key changes include:

Routing and Terminology Updates:

Component Updates:

Localization:

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes in this pull request primarily focus on updating the terminology and routing related to logging functionalities within the application. This includes renaming various routes and components from "daily rounds" to "log updates," enhancing localization entries for logging, and ensuring consistent terminology across the application. Additionally, modifications were made to related notification events and test cases to align with these updates.

Changes

File Path Change Summary
public/locale/en.json Added localization entries for log updates: "log_update", "log_updates", and "no_log_updates".
src/Routers/routes/ConsultationRoutes.tsx Updated route paths from "daily-rounds" to "log_updates" for various consultation-related routes.
src/common/constants.tsx Changed notification event texts from "Patient Consultation Update" to "Patient Log Update".
src/components/Facility/ConsultationCard.tsx Updated button navigation from /daily-rounds to /log_updates/ and changed button label for translation.
src/components/Facility/ConsultationDetails/ConsultationUpdatesTab.tsx Renamed references from "daily_rounds" to "log_updates" and updated imports accordingly.
src/components/LogUpdate/CriticalCareEditor.tsx Changed button href from /daily-rounds/${props.id}/update to /log_updates/${props.id}/update.
src/components/LogUpdate/CriticalCarePreview.tsx Updated title to use {t("log_updates")} for localization and refined visibility logic.
src/components/Notifications/NotificationsList.tsx Updated URL paths in resultUrl function for notification events to reflect "log_updates".
src/components/Notifications/ShowPushNotification.tsx Modified return paths in resultUrl for notification events to use "log_updates".
src/components/Patient/DailyRoundListDetails.tsx Changed title and back URL to use "log_updates" instead of "daily-rounds".
src/components/Patient/DailyRounds.tsx Updated header and button text to reflect "log_updates" and changed navigation paths accordingly.
src/components/Patient/PatientInfoCard.tsx Updated button href to point to "log_updates" and added error handling for bed assignment.
cypress/e2e/patient_spec/PatientLogUpdate.cy.ts Renamed button identifiers from "Daily Rounds" to "Log Updates" in test cases.
tailwind.config.js Reformatted content array for improved readability.
cypress/pageobject/Patient/PatientConsultation.ts Updated selector and button text for viewing consultations to reflect "Log Updates".
src/components/Facility/ConsultationDetails/Events/EventsList.tsx Updated import path for LoadingLogUpdateCard.
src/components/Facility/Consultations/LogUpdates/DefaultLogUpdateCard.tsx Updated import path and href attributes for buttons to reflect "log_updates".
src/components/Facility/Consultations/LogUpdates/VirtualNursingAssistantLogUpdateCard.tsx Updated import path for LogUpdateCardAttribute.
src/components/Facility/Consultations/LogUpdatesFilter.tsx Renamed component from DailyRoundsFilter to LogUpdatesFilter.
src/components/Facility/Consultations/LogUpdatesList.tsx Renamed component from DailyRoundsList to LogUpdatesList and updated import paths.

Assessment against linked issues

Objective Addressed Explanation
Consistency in terminology for log updates (7350) ✅
Update routing paths to reflect log updates terminology (7350) ✅
Update localization for log updates (7350) ✅

Possibly related PRs

Suggested labels

tested, good to merge

Suggested reviewers

Poem

In the land of logs, where updates flow,
From daily rounds to new paths we go.
With translations bright, and routes so clear,
Our logging journey brings us cheer!
Hops and jumps, we celebrate this day,
For every log update, hip-hip-hooray! 🐇✨

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
src/components/Facility/ConsultationDetails/ConsultationUpdatesTab.tsx Oops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.json': Cannot find module '@typescript-eslint/parser' Require stack: - /.eslintrc.json at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15) at Function.resolve (node:internal/modules/helpers:145:19) at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46) at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28) at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 weeks ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 54c6464eaabf10a58642948095e79dbaccf5507e
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6735e78d6fc9e20008ca62be
Deploy Preview https://deploy-preview-9089--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 2 weeks ago

:wave: Hi, @yash-learner, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

yash-learner commented 1 week ago

Things to check:

yash-learner commented 1 week ago

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/components/Facility/Consultations/DailyRounds/DefaultLogUpdateCard.tsx (1)> Line range hint 1-15: Update import paths to reflect new terminology.

The import path still contains "DailyRounds" which should be updated to maintain consistency with the new "LogUpdate" terminology.

- import LogUpdateCardAttribute from "@/components/Facility/Consultations/DailyRounds/LogUpdateCardAttribute";
+ import LogUpdateCardAttribute from "@/components/Facility/Consultations/LogUpdates/LogUpdateCardAttribute";

Note: This change would require moving the file to the new directory structure. Would you like me to help create a GitHub issue to track this refactoring task?

📜 Review details

@rithviknishad Do you think this change is required as of now ?

rithviknishad commented 1 week ago

@yash-learner yes let's do that too

yash-learner commented 1 week ago

@yash-learner yes let's do that too

@rithviknishad

Fixed it in https://github.com/ohcnetwork/care_fe/pull/9089/commits/eccc86a375776fb3c7f8745e0c171649113cbe2e

github-actions[bot] commented 1 week ago

@yash-learner Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: