Updated Test Details page form UI

modamaan commented 6 days ago

Proposed Changes

Fixes #9120

older

updated Screenshot 2024-11-16 025300

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

Summary by CodeRabbit

New Features
- Introduced a new Badge component for improved status and result display.
- Added a Card system with structured layouts for displaying sample details.
- Implemented a Separator component for better visual distinction between sections.
Improvements
- Enhanced UI organization and responsiveness of the SampleDetails component.
- Updated styling for better clarity and presentation of patient information.

netlify[bot] commented 6 days ago

Deploy Preview for care-ohc failed.

Name	Link
Latest commit	df0009347765ccc0f326475e788e443f33338c29
Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/673a523b95a08600086ec935

coderabbitai[bot] commented 6 days ago

Walkthrough

The changes in this pull request primarily enhance the SampleDetails component's UI by restructuring its layout and introducing new UI components such as Badge, CardContent, CardHeader, and Separator. The rendering logic has been modified to improve visual clarity and organization while maintaining existing functionality. Additionally, a new Badge component has been created, along with a set of card components for better styling and layout management. The overall aim is to provide a cleaner and more responsive user interface.

Changes

File	Change Summary
`src/components/Patient/SampleDetails.tsx`	Updated layout using `CardHeader` and `CardContent`, added badges for status and result, and introduced separators.
`src/components/ui/badge.tsx \| Added a new`Badge`component with styling variants using`class-variance-authority`.
`src/components/ui/card.tsx \| Introduced a set of card components (`Card`,`CardHeader`,`CardContent`, etc.) for structured UI presentation.
`src/components/ui/separator.tsx \| Added a new`Separator` component for visual separation of content, supporting customizable orientation and styling.
`vite.config.mts`	Modified configuration to include `@radix-ui/react-separator` in dependencies and mark it as external.
`tsconfig.json`	Updated `include` paths to expand TypeScript compilation scope to include `"src/@types"`.

Assessment against linked issues

Objective	Addressed	Explanation
UI that's clean and easy to read (#9120)	✅

Possibly related PRs

#8960: This PR modifies the same SampleDetails.tsx file, enhancing it with internationalization support, which is relevant to the changes made in the main PR that also focuses on the SampleDetails component.
#9006: This PR involves modifications to the PatientHome.tsx component, which includes updates to the handling of shifts and localization, indicating a broader context of changes related to patient details that may connect with the UI improvements in the SampleDetails component.
#9070: This PR addresses the handling of internationalization (I18n) paths, which is relevant to the main PR's focus on enhancing the UI and potentially its localization aspects in SampleDetails.tsx.

Suggested labels

tested, good to merge

Suggested reviewers

rithviknishad
Jacobjeevan
shivankacker

Poem

In the land of samples, bright and clear,
A badge of honor now appears!
Cards align with headers proud,
Patient details stand out loud.
With separators neat, they find their place,
A joyful UI, a happy space! 🐇✨

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between 54685a4bce8002ac5e979c258eb92cb686cc92a1 and df0009347765ccc0f326475e788e443f33338c29.

📒 Files selected for processing (1)

* `tsconfig.json` (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

* tsconfig.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 4 days ago

:wave: Hi, @modamaan, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

nihal467 commented 3 days ago

@modamaan check through the coderabbit suggestion , fix the issues with the PR, and once the PR is ready for review Tag me

ohcnetwork / care_fe