search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
255 stars 441 forks source link

Facility bed capacity verification test #9145

Open Jacobjeevan opened 5 days ago

Jacobjeevan commented 5 days ago

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 5 days ago

Walkthrough

The changes involve significant enhancements to various Cypress test files and page objects related to facility and patient management. Key modifications include the introduction of structured data handling for facilities and patients, refactoring of test cases to improve readability and maintainability, and the addition of new methods for managing beds and patient data. The updates also streamline interactions with the UI, ensuring that the tests are more concise and organized while retaining the original functionality and error handling mechanisms.

Changes

File Path Change Summary
cypress/e2e/facility_spec/FacilityCreation.cy.ts Added structured data handling for facility creation, refactored test cases to use createNewFacility.
cypress/e2e/facility_spec/FacilityHomepage.cy.ts Introduced new imports and constants, added a test case for bed capacity badge reflection.
cypress/e2e/facility_spec/FacilityLocation.cy.ts Consolidated bed management methods, updated visibility checks, streamlined test cases.
cypress/e2e/patient_spec/PatientRegistration.cy.ts Refactored patient creation to use newPatientData object, enhancing data handling.
cypress/pageobject/Facility/FacilityCreation.ts Introduced FacilityData interface, added methods for creating facilities with structured data.
cypress/pageobject/Facility/FacilityHome.ts Updated clickFacilityNotifyButton method for improved selector handling.
cypress/pageobject/Facility/FacilityLocation.ts Added addBed and editBed methods, enhanced button click methods with { force: true }.
cypress/pageobject/Facility/FacilityManage.ts Added visitViewPatients method for patient management.
cypress/pageobject/Patient/PatientCreation.ts Introduced PatientData interface, added methods for streamlined patient management.
cypress/pageobject/Patient/PatientHome.ts Added typePatientName method for patient name input.
cypress/pageobject/Users/ManageUserPage.ts Added methods for asserting facility badge content and background color.
src/components/Facility/FacilityCard.tsx Added data-test-id attribute to occupancy badge text for improved testability.
src/components/Patient/PatientHome.tsx Enhanced accessibility with new id attributes, refined error handling and layout.

Assessment against linked issues

Objective Addressed Explanation
Verify the functionality of the occupancy badge on the facility card (9107) ✅
Ensure that the badge reflects the updated bed count after adding a bed (9107) ✅
Add API request verification where required using cy.intercept() (9107) ❌ No specific intercepts added.
Reuse existing custom functions and those in commands.ts where possible (9107) ❓ Unclear if all functions reused.
Verify that the occupancy badge displays correctly (9107) ✅

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

Poem

🐇 In the land of tests, we hop and play,
With structured data, we clear the way.
Facilities and patients, all in a line,
Our Cypress tests now truly shine!
So here’s to the changes, both big and small,
In the world of code, we’ll conquer all! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 5 days ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 3af5173b73902bf4c03f945e364158c1779c694c
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67405b70be9f99000808c1e9
Deploy Preview https://deploy-preview-9145--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 days ago

:wave: Hi, @Jacobjeevan, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] commented 1 day ago

:wave: Hi, @Jacobjeevan, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.