search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
255 stars 441 forks source link

fixed the condition in cypress video artefact upload #9149

Closed khavinshankar closed 4 days ago

khavinshankar commented 4 days ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 days ago

Walkthrough

The pull request modifies the Cypress workflow configuration in the .github/workflows/cypress.yaml file. The if condition for uploading Cypress videos is updated to ensure uploads only occur when the workflow fails and the pull request is forked. Additionally, the CYPRESS_RECORD_KEY environment variable is removed from the Cypress run for Forked PRs step, which may influence the recording of test results for forked pull requests. The overall structure and sequence of the workflow remain unchanged.

Changes

File Change Summary
.github/workflows/cypress.yaml Updated if condition for video uploads; removed CYPRESS_RECORD_KEY from forked PR step.

Possibly related PRs

Poem

🐇 In the garden where tests bloom bright,
Cypress dances in the soft moonlight.
Forked PRs now with videos to share,
Only on failure, they float in the air.
With a hop and a skip, we refine our way,
Celebrating changes, come what may! 🌼

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 2eaf15ef9688463752d63560e922ef7a8e12c3c2 and 3897797514aacb2f93733f93305333f6deeec25c.
📒 Files selected for processing (1) * `.github/workflows/cypress.yaml` (1 hunks)
🔇 Additional comments (1)
.github/workflows/cypress.yaml (1) `135-135`: **LGTM! Improved video artifact upload condition.** The updated condition `failure() && steps.pr_origin.outputs.is_forked == 'true'` is a good improvement as it ensures videos are only uploaded when: 1. The workflow fails (when they're most needed for debugging) 2. The PR is from a forked repository

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 4 days ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 3897797514aacb2f93733f93305333f6deeec25c
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/673b15015d3e1000081e22a5
Deploy Preview https://deploy-preview-9149--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages[bot] commented 4 days ago

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3897797
Status: ✅  Deploy successful!
Preview URL: https://09390e87.care-fe.pages.dev
Branch Preview URL: https://cypress-video-artefact.care-fe.pages.dev

View logs

cypress[bot] commented 4 days ago

CARE    Run #3920

Run Properties:  status check passed Passed #3920  •  git commit 53f7d03763: fixed the condition in cypress video artefact upload
Project CARE
Branch Review cypress-video-artefact
Run status status check passed Passed #3920
Run duration 04m 53s
Commit git commit 53f7d03763: fixed the condition in cypress video artefact upload
Committer Khavin Shankar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎
github-actions[bot] commented 4 days ago

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: