search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
255 stars 441 forks source link

fix: Resolve creation of patient name despite having numeric values #9152

Closed Tanuj1718 closed 2 days ago

Tanuj1718 commented 3 days ago

Proposed Changes

https://github.com/user-attachments/assets/59b5ac7b-3ad8-477a-9a85-f5113b205f1a

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 3 days ago

Walkthrough

The changes in the PatientRegister.tsx component focus on enhancing the validation logic for patient names within the form handling process. A new validation function, validateName, has been introduced to ensure that names do not contain numeric values. The form initialization now includes a name field, and the validation logic has been updated accordingly. Additionally, the submission handling has been adjusted to format the name correctly before processing.

Changes

File Change Summary
src/components/Patient/PatientRegister.tsx Integrated validateName for name validation, updated form initialization to include a name field, modified validateForm for new validation, and adjusted handleSubmit for name formatting.

Assessment against linked issues

Objective Addressed Explanation
Prevent creation of patients with numeric values in name (#9143) ✅

Poem

🐇 In the garden where names bloom bright,
A rabbit hops with pure delight.
With validations strong and true,
No numbers in names, just skies so blue!
So patients' names, all neat and fair,
Are crafted with love, beyond compare! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 3 days ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 7ba4669f7d82e9e7c0fb5c4d27225e0064885c63
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/673bbd5b2c060c00087fa615
Deploy Preview https://deploy-preview-9152--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shivankacker commented 3 days ago

@Tanuj1718 have we also accounted for characters like underscores, dots and commas ?

Tanuj1718 commented 2 days ago

@Tanuj1718 have we also accounted for characters like underscores, dots and commas ?

Yes we have checked. We only allow alphabetic characters and spaces in Name.

nihal467 commented 2 days ago

LGTM

github-actions[bot] commented 2 days ago

@Tanuj1718 Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

rithviknishad commented 20 hours ago

@Tanuj1718 #9177 would be reverting this PR due to reason mentioned in https://github.com/ohcnetwork/care_fe/issues/9143#issuecomment-2491409154

Tanuj1718 commented 9 hours ago

@Tanuj1718 #9177 would be reverting this PR due to reason mentioned in #9143 (comment)

Okay @rithviknishad , it's always interesting to know about the new things.