search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
257 stars 443 forks source link

Make integrations toggle-able during build #9160

Open sainak opened 6 days ago

sainak commented 6 days ago

Proposed Changes

[!NOTE] New required environment variables REACT_SENTRY_DSN, REACT_SENTRY_ENABLED, REACT_SENTRY_DSN

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 6 days ago

Walkthrough

The changes in this pull request involve modifications to the Sentry integration and configuration across multiple files. Key updates include the removal of the Sentry component from the main application, the introduction of new functions for Sentry initialization and error capturing, and adjustments to the configuration to streamline integration based on environment variables. Additionally, a new file for a disabled version of the Plausible integration is introduced, and the Vite configuration is updated to support dynamic aliasing for integrations.

Changes

File Change Summary
care.config.ts Updated sentry.dsn to env.REACT_SENTRY_DSN and sentry.environment to default to "unknown".
src/App.tsx Removed <Integrations.Sentry /> component from render method.
src/Integrations/Plausible-disabled.tsx Added a new function Plausible that returns null and an empty triggerGoal function.
src/Integrations/Sentry-disabled.tsx Introduced initSentry and captureException functions with empty implementations.
src/Integrations/Sentry.tsx Replaced component with initSentry and captureException functions for Sentry integration.
src/Integrations/index.tsx Removed Sentry from the Integrations export.
src/components/Notifications/NotificationsList.tsx Updated error handling to use new captureException method.
src/hooks/useNotificationSubscriptionState.ts Changed Sentry import to use local captureException function for error handling.
src/index.tsx Modified Sentry initialization to use initSentry function and separated service worker registration.
src/vite-env.d.ts Added optional properties for REACT_PLAUSIBLE_ENABLED and REACT_SENTRY_ENABLED.
vite.config.mts Introduced SUPPORTED_INTEGRATIONS constant and getIntegrationsAlias function for dynamic aliasing.

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

🐰 In the meadow, changes bloom,
Sentry's whispers clear the gloom.
With integrations now refined,
Errors caught, no longer blind.
Plausible paths, a new delight,
Hopping forward, all feels right! 🌼

[!WARNING]

Rate limit exceeded

@sainak has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between a8cacaacb8b8b3f55fc1fd979ab3a90b867eb2a6 and c98638b566acd447d9eaede8393f4996c3535d96.

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
src/Integrations/Sentry-disabled.tsx Oops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.json': Cannot find module '@typescript-eslint/parser' Require stack: - /.eslintrc.json at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15) at Function.resolve (node:internal/modules/helpers:145:19) at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46) at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28) at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 6 days ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit c98638b566acd447d9eaede8393f4996c3535d96
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/673c958e90f9e7000806c754
Deploy Preview https://deploy-preview-9160--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages[bot] commented 6 days ago

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: c98638b
Status: ✅  Deploy successful!
Preview URL: https://ed36dc93.care-fe.pages.dev
Branch Preview URL: https://sainak-toggleable-integratio.care-fe.pages.dev

View logs

cypress[bot] commented 6 days ago

CARE    Run #3925

Run Properties:  status check passed Passed #3925  •  git commit c98638b566: Make integrations toggle-able during build
Project CARE
Branch Review sainak/toggleable-integrations
Run status status check passed Passed #3925
Run duration 04m 50s
Commit git commit c98638b566: Make integrations toggle-able during build
Committer Aakash Singh
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 129
View all changes introduced in this branch ↗︎
sainak commented 6 days ago

@coderabbitai review

coderabbitai[bot] commented 6 days ago
:white_check_mark: Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
github-actions[bot] commented 5 days ago

:wave: Hi, @sainak, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.