search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
255 stars 441 forks source link

issue #9156 fixed #9161

Open gurramkarthiknetha opened 2 days ago

gurramkarthiknetha commented 2 days ago

image image image image image this are the changes made by me.

Summary by CodeRabbit

Release Notes

These changes aim to enhance user experience and improve functionality across the application.

coderabbitai[bot] commented 2 days ago

Walkthrough

The changes in this pull request focus on modifying the layout and styling of various UI components across multiple files. Key updates include enhancements to margin and spacing for buttons and containers, adjustments to the rendering logic of tooltips, and refinements in the handling of state variables related to user interactions. Additionally, the control flow for managing patient consent records has been improved to ensure better user experience and data integrity.

Changes

File Path Change Summary
src/CAREUI/interactive/FiltersSlideover.tsx Updated className of AdvancedFilterButton to include mt-2 for margin-top styling.
src/components/Common/ButtonV2.tsx Added mt-required class to button styles; refined tooltip rendering logic.
src/components/Common/Menu.tsx Added mt-2 class to MenuButton for improved spacing.
src/components/Facility/FacilityCard.tsx Changed class name for facility details layout to include gap-2; updated notification button layout.
src/components/Kanban/Board.tsx Enhanced responsiveness with new CSS classes for KanbanBoard and KanbanSection; clarified data handling.
src/components/Patient/ManagePatients.tsx Updated button layout for filtering/exporting; improved onTabChange logic based on user roles.
src/components/Patient/PatientConsentRecords.tsx Introduced showPCSChangeModal state; modified upload logic to check for existing consent records.

Possibly related PRs

Suggested labels

needs review, needs testing

Suggested reviewers

🐇 In the code, I hop and play,
With buttons styled in a new way.
Margins added, gaps so neat,
A joyful UI, oh what a treat!
With consent records, we now glide,
In a world where changes abide! 🌼

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint (1.23.1) > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
src/components/Common/ButtonV2.tsx Oops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.json': Cannot find module '@typescript-eslint/parser' Require stack: - /.eslintrc.json at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15) at Function.resolve (node:internal/modules/helpers:145:19) at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46) at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28) at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)
📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 31020a279876b300bdf831f6ef9832c5d139ce16 and 88e5236e6936fb8293189979da4128c567f1ef5f.
📒 Files selected for processing (1) * `src/components/Common/ButtonV2.tsx` (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * src/components/Common/ButtonV2.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 days ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit 88e5236e6936fb8293189979da4128c567f1ef5f
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/673f83093cdac000081c5bca
Deploy Preview https://deploy-preview-9161--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jacobjeevan commented 2 days ago

Also follow the PR format what we have (refer to other PRs). Edit the title to be readable as well.

Jacobjeevan commented 1 day ago

Also follow the PR format what we have (refer to other PRs). Edit the title to be readable as well.

Also this ☝️ @gurramkarthiknetha

gurramkarthiknetha commented 17 hours ago

Now i kept from the same branch . Did i need to change any more

rithviknishad commented 7 hours ago

@gurramkarthiknetha It's required to follow the original PR template and link the issue in it. Also keep a proper readable title that conveys what has changed in the PR.