search

ohcnetwork / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
255 stars 441 forks source link

Refactored the pagination component in cypress #9163

Closed nihal467 closed 1 day ago

nihal467 commented 2 days ago

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 days ago

Walkthrough

The changes in this pull request involve the integration of a new pagination helper across multiple test files, replacing the previous AssetPagination class. The pageNavigation utility is introduced to streamline pagination functionality, including methods for navigating between pages and verifying the current page number. The modifications affect several test files, ensuring that pagination logic is centralized and enhancing the maintainability of the test code.

Changes

File Path Change Summary
cypress/e2e/assets_spec/AssetHomepage.cy.ts Removed AssetPagination import; added pageNavigation import; updated pagination methods.
cypress/e2e/facility_spec/FacilityHomepage.cy.ts Removed AssetPagination import; added pageNavigation import; updated pagination methods.
cypress/e2e/facility_spec/FacilityLocation.cy.ts Removed AssetPagination import; added pageNavigation import; updated pagination methods.
cypress/e2e/patient_spec/PatientHomepage.cy.ts Added pageNavigation import; replaced pagination methods with pageNavigation methods.
cypress/e2e/users_spec/UsersHomepage.cy.ts Added pageNavigation import; replaced pagination methods with pageNavigation methods.
cypress/pageobject/Asset/AssetPagination.ts Removed the entire AssetPagination class and its associated methods.
cypress/pageobject/Patient/PatientHome.ts Removed pagination-related methods: clickNextPage, verifySecondPageUrl, clickPreviousPage.
cypress/pageobject/Users/UserSearch.ts Removed pagination-related methods: navigateToNextPage, navigateToPreviousPage, verifyCurrentPageNumber.
cypress/pageobject/utils/paginationHelpers.ts Introduced new paginationHelpers.ts file with pageNavigation object and pagination methods.
cypress/e2e/hcx_spec/HcxClaims.cy.ts Updated patient name variable from "Dummy Patient 14" to "Dummy Patient Thirteen".
cypress/e2e/patient_spec/PatientBedManagement.cy.ts Updated patient names from numerical to word forms.
cypress/e2e/patient_spec/PatientConsultationCreation.cy.ts Updated patient identifier from "Dummy Patient 13" to "Dummy Patient Thirteen".
cypress/e2e/patient_spec/PatientConsultationDischarge.cy.ts Updated patient identifiers to more descriptive names.
cypress/e2e/patient_spec/PatientDoctorConnect.cy.ts Updated patient and doctor names to more descriptive forms.
cypress/e2e/patient_spec/PatientDoctorNotes.cy.ts Updated patient name from "Dummy Patient 4" to "Dummy Patient Four".
cypress/e2e/patient_spec/PatientFileUpload.ts Updated patient names from numerical to word forms.
cypress/e2e/patient_spec/PatientInvestigation.cy.ts Updated patient name from "Dummy Patient 14" to "Dummy Patient Thirteen".
cypress/e2e/patient_spec/PatientLogUpdate.cy.ts Updated patient identifiers from numerical to word forms.
cypress/e2e/patient_spec/PatientPrescription.cy.ts Updated patient names from numerical to word forms.
cypress/e2e/patient_spec/PatientRegistration.cy.ts Updated patientTransferName from "Dummy Patient 10" to "Dummy Patient Twelve".
cypress/e2e/sample_test_spec/SampleTestRequest.cy.ts Updated patient name from "Dummy Patient 11" to "Dummy Patient Eleven".

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

Poem

🐰 In the fields where rabbits play,
Pagination hops along the way.
With pageNavigation now in sight,
Our tests will run both fast and bright.
Goodbye to old, hello to new,
Hopping pages, just for you! 🌼

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
cypress/e2e/patient_spec/PatientRegistration.cy.ts Oops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.json': Cannot find module '@typescript-eslint/parser' Require stack: - /.eslintrc.json at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15) at Function.resolve (node:internal/modules/helpers:145:19) at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46) at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28) at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)
📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 2fb5503c17891d724531fae986da8f906f73b40c and bddb37d18ba9a8782cfd2b20f15f9eff62c6b23d.
📒 Files selected for processing (1) * `cypress/e2e/patient_spec/PatientRegistration.cy.ts` (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * cypress/e2e/patient_spec/PatientRegistration.cy.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 days ago

Deploy Preview for care-ohc ready!

Name Link
Latest commit bddb37d18ba9a8782cfd2b20f15f9eff62c6b23d
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/673dddaf76843e0008bcddf4
Deploy Preview https://deploy-preview-9163--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages[bot] commented 2 days ago

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: bddb37d
Status: ✅  Deploy successful!
Preview URL: https://64f487c3.care-fe.pages.dev
Branch Preview URL: https://pagination-helper-function.care-fe.pages.dev

View logs

cypress[bot] commented 2 days ago

CARE    Run #3935

Run Properties:  status check passed Passed #3935  •  git commit bddb37d18b: Refactored the pagination component in cypress
Project CARE
Branch Review pagination-helper-function
Run status status check passed Passed #3935
Run duration 04m 52s
Commit git commit bddb37d18b: Refactored the pagination component in cypress
Committer Mohammed Nihal
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 129
View all changes introduced in this branch ↗︎
github-actions[bot] commented 1 day ago

@nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: