search

okfn / opendatahandbook-old

Open Data Handbook
http://opendatahandbook.org/
68 stars 39 forks source link

Limited line lengths to around 70-79 characters, making diffs much more readable. #41

Closed deeplook closed 12 years ago

timClicks commented 12 years ago

Thanks. I'm sorry fo tell you this, but this work has already been completed. See #40

timClicks commented 12 years ago

On second thoughts, it looks like your work is much more aggressive than mine. I expect this commit is more comprehensive. I'll merge this into okfn/master, sync my repo with these changes then add a new pull request from my branch for subsequent changes I've made.

deeplook commented 12 years ago

Ok... Anyway, I think titles like "Behind the scenes changes" are too vague and require others to inspect the list of changes inside. I'd rather prefer non-compound changesets where possible.

timClicks commented 12 years ago

I prefer pull requests to be broad and commit messages to be specific. In fact, I would prefer that people are required to inspect the individual files rather than take the title at face value.