search

olavolav / uniplot

Lightweight plotting to the terminal. 4x resolution via Unicode.
MIT License
343 stars 16 forks source link

Fix bin range default check. #28

Closed riga closed 2 months ago

riga commented 2 months ago

Hi @olavolav ,

this PR contains a small fix for the evaluation of defaults for the bins_min and bins_max arguments. I noticed that, when explicitly setting them to 0, the histograms fallback to the min/max of the input series.

I changed the checks to explicitly check for None, to avoid 0 being mistakenly interpreted as "ranges not provided".

olavolav commented 2 months ago

Perfect thank you!