Format Document not using tab size of 3

anthonynorthrup314 commented 5 years ago

Issue:

When formatting my C# file, it does not appear to properly get the indentation level I configured. It properly uses spaces instead of tabs, however it puts 4 spaces when all languages have 3 specified.

System information:

OS: Windows 10 Pro 1709 (16299.248)
Notepad++ installer used (latest from downloads page at time of posting): https://notepad-plus-plus.org/repository/7.x/7.7/npp.7.7.Installer.x64.exe
CS-Script version (latest from this repository at time of posting), acquired via Plugins Admin: 1.7.24

Reproduction steps: https://www.screencast.com/t/2MnRTThoRigJ

Minimalist install, with Plugins Admin
Once installed: Settings -> Preferences -> Language -> [Default]
- Tab size: 3
- Replace by space: Checked
Ensure every language has "Use default value" checked (I only needed to fix this for python and yaml)
Close and reopen notepad++
Ensure the indent settings were preserved
Plugins -> Plugins Admin
- Check "CS-Script - C# Intellisense" version "1.7.24"
- Click Install, and let it restart notepad++
Notice the warning about auto-complete (https://github.com/oleg-shilo/cs-script.npp/wiki/Dealing-with-Notepad%E2%80%A0%E2%80%A0-native-auto-complete)
Settings -> Preferences -> Auto-Completion
- Uncheck "Enable auto-completion on each input"
- Uncheck "Function parameters hint on input"
Close and reopen notepad++
Ensure the indent settings were preserved
Type the following into a new file, and save to C:\temp\Test.cs

using System;

namespace Foo
{
class Bar
{
public static void main(String[] args)
{
Console.WriteLine("Press Enter to continue...");
Console.ReadLine();
}
}
}

Edit -> Select All
Plugins -> CS-Script -> Format Document
Notice it uses four spaces for indentation

oleg-shilo commented 5 years ago

Hi Antony,

This is a tricky issue to solve.The problem is that C# formatting is done by the external component based on Roslyn C# syntax engine, which has nothing to do with N++. Thus the there is no way for the formatter to discover the current N++ setting. Thus the formatting is done according default Roslyn settings that reflect styling preferences commonly accepted in C# community. Which are... "4 spaces instead of tabs".

Nevertheless it is a valid feature request and I will try to integrate Roslyn settings with N++ ones.

oleg-shilo commented 5 years ago

Hi Antony,

This is a tricky issue to solve.The problem is that C# formatting is done by the external component based on Roslyn C# syntax engine, which has nothing to do with N++. Thus the there is no way for the formatter to discover the current N++ setting. Thus the formatting is done according default Roslyn settings that reflect styling preferences commonly accepted in C# community. Which are... "4 spaces instead of tabs".

Nevertheless it is a valid feature request and I will try to integrate Roslyn settings with N++ ones.

oleg-shilo / cs-script.npp