ollo69 / ha_tuya_custom

Tuya Custom Component for testing
Apache License 2.0
39 stars 18 forks source link

climate max and min temperature #45

Open arebollom opened 3 years ago

arebollom commented 3 years ago

Hello,

I think there is a bug when applying the variable "_tempdivider" since it should not apply to _mintemp and _maxtemp. This variable should be only for _targettemperature

Max: image

Min: image broken because es lower than 4ºc

arebollom commented 3 years ago

I have solved it locally, divided the two value:

    def min_temp(self):
        return self._set_decimal(self.data.get("min_temper"),1)

    def max_temp(self):
        return self._set_decimal(self.data.get("max_temper"),1)
ollo69 commented 3 years ago

At this moment I'm working on standard Tuya component to move back this component feature. I don't think that rule than min_temp and max_temp must not be divided is always valid, more probably your device is an exception. I will eventually add the possibility to also define min and max as separate parameter in standard integration.

edubox commented 3 years ago

Same problem here, I can't set temperature higher than 18º

ollo69 commented 3 years ago

Please be patient. This will be fixed soon in standard Tuya integration, working on this...

edubox commented 3 years ago

Please be patient. This will be fixed soon in standard Tuya integration, working on this...

Thanks! Not rush, just to inform :) Thanks for your job

browetd commented 3 years ago

Same problem here (with aixi-SHS Wireless Wi-Fi thermostat). Before version HA 0.117, the temperature was 10 times the real temperature now it is 10 times smaller (I think)... with "official Tuya" integrated in HA or Tuya-Custom but Tuya-custom seems to give more acurate temperature than "official Tuya". Example: in Tuya App, current temperature is 12.5°C, target temperature is 5°C, min temp is 5°C and max temp is 35°C, here is what I have in HA with Tuya-custom (the hvac_modes is strange too: heat_cool (?) but I can change my automations if these are the new modes, the only correct information for me is the target temperature step equal to 0.5°C):

climate.XXXXXX heat_cool hvac_modes: off, heat_cool min_temp: 0.1 max_temp: 12.2 target_temp_step: 0.5 current_temperature: 1.2 temperature: 0.5 tuya_device_id: XXXXXXX friendly_name: Salle de Bain Etage supported_features: 1

Thank you for your help and hard work !