search

ome / omero-web-apps-examples

Example Setup for Web Apps
1 stars 4 forks source link

Add minimal web app example #3

Closed will-moore closed 4 years ago

will-moore commented 5 years ago

To test:

Follow instructions at https://github.com/will-moore/omero-web-apps-examples to install minimal example in virtualenv.

Same with React app with instructions at https://github.com/will-moore/omero-web-apps-examples/tree/master/react-webapp

sbesson commented 5 years ago

Generally :+1: for the creation and maintainenance of a template web app repo. What is the relationship with https://github.com/ome/omero-webtest which was originally created with a similar intent? Should the latter be deprecated in favor of this one?

jburel commented 5 years ago

webtest should probably be deprecated

will-moore commented 5 years ago

Webtest contains a bunch of sample code, similar to e.g. Python or Java snippets we have in examples/Training/ whereas this repo will be minimal boilerplate on how to set up a web app. There is plenty of code in webtest that will not be ported here, so I guess we need to decide whether those are useful samples. Webtest is linked in the docs in a few places, so we'd need to update them.

sbesson commented 5 years ago

Understood. I can certainly see the value of keeping example code separated from a minimal boilerplate template repository. However, I think there is a naming problem in that case. Without reading anything, I naturally assumed omero-web-apps-examples would contain example codes for setting up web apps. Reading a bit through https://github.com/ome/ome-documentation/pull/2015/files, I now understand its intent. If the scope does not evolve, would it make sense to rename this repository more simply as omero-web-apps-templates?

will-moore commented 5 years ago

@sbesson Yes, I can see that omero-web-apps-templates would make sense.

joshmoore commented 5 years ago

https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-docs is green again just by merging the upstream PR: https://github.com/ome/ome-documentation/pull/2015

Noticed there are a number of open comments here, @will-moore. Leaving you a chance to go over this and split/remove/change as necessary.

joshmoore commented 5 years ago

@will-moore : how do you want to solve this conflict?

will-moore commented 4 years ago

Since https://docs.openmicroscopy.org/omero/5.6.0-m4/developers/Web/CreateApp.html now asks users to use git clone git@github.com:ome/omero-web-apps-examples.git, that workflow is broken until this PR is merged.

jburel commented 4 years ago

Thanks merging

jburel commented 4 years ago

See https://github.com/ome/omero-web-apps-examples/releases/tag/v0.2.0