search

ome / omero-web-apps-examples

Example Setup for Web Apps
1 stars 4 forks source link

Cookiecutter for the minimal-webapp #7

Open glyg opened 2 years ago

glyg commented 2 years ago

Hi,

Thank you for the template code. I created a cookiecutter for the minimal-webapp example:

https://gitlab.in2p3.fr/fbi-data/omero-webapp-cookiecutter

This automates the renaming in all the boilerplate code, and could be extended to the react app. I don't know if it can find a place in the ome org here, but would be happy to contribute.

This can also just be a mention in the REAME of course :)

will-moore commented 2 years ago

That's great, Thanks! - I've been meaning to get around to doing that for a while. It would be nice to replace this 'examples' repo with a cookiecutter. I don't think we need both. I also think we shouldn't include the React app - There are too many JS choices for users these days and they keep changing so I think this Django example app should have as little JS as possible.

cc @jburel @sbesson Maybe we should delete or rename this repo since omero-web-apps-examples should be just a single example. Either omero-webapp-example or omero-webapp-cookiecutter if it's a convention for cookiecutter apps to have that in their name?

glyg commented 2 years ago

Thanks @will-moore !

it's a convention for cookiecutter apps to have that in their name?

Looks like it :wink:

sbesson commented 2 years ago

Big :+1: for having cookiecutters, we already have some minimal prototype for CLI - https://github.com/ome/cookiecutter-omero-cli-plugin.

cc @jburel @sbesson Maybe we should delete or rename this repo since omero-web-apps-examples should be just a single example. Either omero-webapp-example or omero-webapp-cookiecutter if it's a convention for cookiecutter apps to have that in their name?

I would not delete a repo in all cases, but it's easy enough to archive and have a README redirecting to the appropriate place.

I don't know if it can find a place in the ome org here, but would be happy to contribute.

Barring the minimal testing and the discussion of the name and the style 😄 I would be absolutely fine with having something similar to https://github.com/ome/cookiecutter-omero-webapp

glyg commented 2 years ago

great! I'll try to set tests up on the gitlab repo. I feel it's easier to have a cookiecutter for the minimal webapp and one for react (which I can also write while I'm at it).

jburel commented 1 year ago

Coming back to this. Something to reactivate post summer

will-moore commented 9 months ago

@glyg - I tested out your omero-webapp-cookiecutter the other day and it worked great. @jburel is going to create a new empty repo at e.g. https://github.com/ome/cookiecutter-omero-webapp and then maybe you could copy your app there as a PR? We'll ping here once the app is created, Thanks!

glyg commented 9 months ago

oh cool :) Sure will do

jburel commented 9 months ago

done

glyg commented 9 months ago

@jburel forking is disabled on the repo, can you authorize it?

jburel commented 9 months ago

Apologies. The repo was private. I changed it to public

glyg commented 9 months ago

The PR is up here: https://github.com/ome/cookiecutter-omero-webapp/pull/1