omerxx / tmux-sessionx

A Tmux session manager, with preview, fuzzy finding, and MORE
GNU General Public License v3.0
565 stars 51 forks source link

bug: the pop-up does not show #22

Closed technophile-04 closed 2 months ago

technophile-04 commented 6 months ago

Description :

https://github.com/omerxx/tmux-sessionx/assets/80153681/b15ad730-411d-4aab-8adc-4a6edbb9e868

For some reason, the session window does not pop open for me the screen just flickers but nothing happens :

My tmux config : https://github.com/technophile-04/tmux.conf

My wezter config : https://github.com/technophile-04/wezterm-config

I also have fzf, bat and zoxide installed through brew

Pardon me if I missed something, also thanks for creating such an awesome plugin !!

alexanderfast commented 6 months ago

I have the same issue. I tried starting with tmux -vvvv and then launch the plugin, after seeing the selection window briefly flicker I exit and inspect the log files generated in the local folder. I can see the sessionx script being executed, but no errors. Not sure how to debug this, but ill join this thread to subscribe to eventual solutions.

luntta commented 6 months ago

I'm having the same issue. Sometimes after trying to open the popup it briefly shows text "scrollbar display width should be 1" before disappearing.

Nitestack commented 6 months ago

I had this bug too. I switched to t-smart-tmux-manager and it didn't work too. So I looked into the issues.

I just had to kill all sessions and create a brand new session then. After that, both plugins work!

Link to that discussion: https://github.com/joshmedeski/t-smart-tmux-session-manager/issues/48#issuecomment-1680966515

alexanderfast commented 6 months ago

Tried to detach and running tmux kill-server but that didnt work, and no matter of config reload or ssh/terminal restarts seems to affect this either.

luntta commented 6 months ago

Tried to detach and running tmux kill-server but that didnt work, and no matter of config reload or ssh/terminal restarts seems to affect this either.

Yeah, not working for me either. Here's my setup:

OS: Ubuntu 23.04 x86_64 Kernel: 6.2.0-39-generic Shell: zsh 5.9 Resolution: 2560x1440, 2560x1440 DE: GNOME 44.3 Terminal: tmux 3.3a

Nitestack commented 6 months ago

So you guys killed each session (so that no client is running) and it didnt work? Strange...

johnmosv commented 6 months ago

I have the same issue on mac with kitty. Tried detaching and killing the server without any effect.

Chris44442 commented 6 months ago

Same issue here. Right now I'm pretty sure it has something to do with fzf. On my one machine I could make it work by installing the v0.45.0 binary from their github and uninstalling the apt version of fzf and doing a bunch of tmux kill-server. But on my other machine the tmux crashes when i open sessionx with fzf 0.45. When I comment out the RESULT=$(echo -e "${INPUT// /}" | fzf-tmux "${args[@]}") line, it doesn't crash (but doesn't work either obviously).

Edit: One thing to note is: "zoxide only supports fzf v0.33.0 and above". Apt version is v0.29.0-1. The Apt version is where the flickering happens.

alexanderfast commented 6 months ago

Just checked and this is my version:

❯ fzf --version
0.38.0 (debian)

I found an alternate session manager for tmux so i wont spend super much more time on this, but ill stay subscribed to the issue and ill check again when/if it's fixed. :)

the-spanish-guy commented 6 months ago

Any updates? I have the same problem :/

TechDufus commented 6 months ago

What version of fzf is everyone using here? fzf --version You may want to consider updating, since the fzf available in apt only installs v0.39 or so, and after I updated from the fzf github release this worked for me.

https://github.com/omerxx/tmux-sessionx/issues/9 https://github.com/omerxx/tmux-sessionx/issues/12

the-spanish-guy commented 6 months ago

What version of fzf is everyone using here? fzf --version You may want to consider updating, since the fzf available in apt only installs v0.39 or so, and after I updated from the fzf github release this worked for me.

9 #12

is v0.43.0 image

omerxx commented 6 months ago

Hi friends! I'll try to figure out the issue you're facing, but in the mean time try using this option, fzf is missing a few features in older versions that I'm using now (by older I mean two years at least).

# If you're running fzf lower than 0.35.0 there are a few missing features
# Upgrade, or use this setting for support
set -g @sessionx-legacy-fzf-support 'on'

If you guys confirm this does the trick I think I'll either remove the functionality as it's not all that important, or better yet, make it ope-in rather than out.

Thanks!

omerxx commented 6 months ago

Just checked and this is my version:

❯ fzf --version
0.38.0 (debian)

I found an alternate session manager for tmux so i wont spend super much more time on this, but ill stay subscribed to the issue and ill check again when/if it's fixed. :)

Can you try to either upgrade your fzf or use set -g @sessionx-legacy-fzf-support 'on'?

omerxx commented 6 months ago

Any updates? I have the same problem :/

Can you please share your relevant config? Seems like you're running a relatively up-to-date fzf so I'm curious why your setup fails

omerxx commented 6 months ago

Description :

Screen.Recording.2023-12-30.at.3.28.26.PM.mov For some reason, the session window does not pop open for me the screen just flickers but nothing happens :

My tmux config : https://github.com/technophile-04/tmux.conf

My wezter config : https://github.com/technophile-04/wezterm-config

I also have fzf, bat and zoxide installed through brew

Pardon me if I missed something, also thanks for creating such an awesome plugin !!

I used your config with no issues, however the plugin is not there (assuming this is why I see an unstaged git change in your video above) so can't replicate everything. Please try these -

omerxx commented 6 months ago

Same issue here. Right now I'm pretty sure it has something to do with fzf. On my one machine I could make it work by installing the v0.45.0 binary from their github and uninstalling the apt version of fzf and doing a bunch of tmux kill-server. But on my other machine the tmux crashes when i open sessionx with fzf 0.45. When I comment out the RESULT=$(echo -e "${INPUT// /}" | fzf-tmux "${args[@]}") line, it doesn't crash (but doesn't work either obviously).

Edit: One thing to note is: "zoxide only supports fzf v0.33.0 and above". Apt version is v0.29.0-1. The Apt version is where the flickering happens.

Thanks for clarifying! So do you think there's an issue with the apt version across the board? If that's really the case my idea with ignoring relatively new fzf features won't do... I wonder whats the best approach here... maybe a preflight check for version or something like that 🤔

johnmosv commented 6 months ago

I can verify updating fzf did it for me. thanks alot!

the-spanish-guy commented 6 months ago

Any updates? I have the same problem :/

Can you please share your relevant config? Seems like you're running a relatively up-to-date fzf so I'm curious why your setup fails

Hello, this is my config and when I press <prefix>+o the terminal freezes, i use kitty but the behavior is the same in other terminals

unbind-key o

# List of plugins
set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'tmux-plugins/tmux-sensible'
set -g @plugin 'catppuccin/tmux'
set -g @plugin 'tmux-plugins/tmux-battery'
set -g @plugin 'sainnhe/tmux-fzf'
set -g @plugin 'omerxx/tmux-sessionx'

set -g @sessionx-bind 'o'

# set -g @catppuccin_status_modules_right "... battery ..."
set -g @catppuccin_window_left_separator ""
set -g @catppuccin_window_right_separator " "
set -g @catppuccin_window_middle_separator " █"
set -g @catppuccin_window_number_position "right"

set -g @catppuccin_window_default_fill "number"
set -g @catppuccin_window_default_text "#W"

set -g @catppuccin_window_current_fill "number"
set -g @catppuccin_window_current_text "#W"

set -g @catppuccin_status_modules_right "directory user session battery"
set -g @catppuccin_status_left_separator  " "
set -g @catppuccin_status_right_separator ""
set -g @catppuccin_status_right_separator_inverse "no"
set -g @catppuccin_status_fill "icon"
set -g @catppuccin_status_connect_separator "no"

set -g @catppuccin_directory_text "#{pane_current_path}"

# Initialize TMUX plugin manager (keep this line at the very bottom of tmux.conf)
run '~/.tmux/plugins/tpm/tpm'
b1tray3r commented 5 months ago

Hi folks!

Found the YouTube video and wanted to install this session manager to my tmux setup... and ended up here in this issue because the popup window didn't open.

After someone in the comments mentioned a log file, I went into the plugins folder to search for such...

I ended up in the scripts' subfolder at this line:

https://github.com/omerxx/tmux-sessionx/blob/main/scripts/sessionx.sh#L16C52-L16C73

Please make sure to enable the pop-up window because it is disabled by default:

set -g @sessionx-window-mode 'on'

Kind regards

Alex

P.S.: This may be added in the documentation, because I ended up installing all the requirements... The YouTube video says "Just add this line..." but this ain't the truth. :D

the-spanish-guy commented 5 months ago

Hi folks!

Found the YouTube video and wanted to install this session manager to my tmux setup... and ended up here in this issue because the popup window didn't open.

After someone in the comments mentioned a log file, I went into the plugins folder to search for such...

I ended up in the scripts' subfolder at this line:

https://github.com/omerxx/tmux-sessionx/blob/main/scripts/sessionx.sh#L16C52-L16C73

Please make sure to enable the pop-up window because it is disabled by default:

set -g @sessionx-window-mode 'on'

Kind regards

Alex

P.S.: This may be added in the documentation, because I ended up installing all the requirements... The YouTube video says "Just add this line..." but this ain't the truth. :D

I set this setting but it still didn't work :/

omurilo commented 5 months ago

Hi guys, any update here? I'm in same problem within Ubuntu and MacOS.

the-spanish-guy commented 5 months ago

I did another test keeping the configuration on Windows (wsl2 with arch) and it worked, I'll try again on Ubuntu later and post updates here

TechDufus commented 5 months ago

I did another test keeping the configuration on Windows (wsl2 with arch) and it worked, I'll try again on Ubuntu later and post updates here

came here to call out this [arch btw] btw.

the-spanish-guy commented 5 months ago

I uninstalled and reinstalled tmux, leaving only tpm and tmux-sessionx as plugins and it didn't work

omerxx commented 5 months ago

Hi everyone, I'd really want to get to the bottom of this. Happy if anyone here wants to jump on a call / try and share their setup.

I'm running latest Tmux + FZF + Zoxide. I use Wezterm and the only time I was able to reproduce it was when the plugin script had a bug / fzf was not updated.

If anyone's interested please comment here or if you use Telegram let's chat directly: https://t.me/omerxx

the-spanish-guy commented 5 months ago

I downloaded and installed Wezterm and it worked, I also tested it with Ubuntu Terminal and it worked so I decided to test it one last time with Kitty and it worked too

image

this is my config

unbind-key o

# List of plugins
set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'tmux-plugins/tmux-sensible'
set -g @plugin 'omerxx/tmux-sessionx'
set -g @plugin 'catppuccin/tmux'

# I recommend using `o` if not already in use, for least key strokes when launching
set -g @sessionx-bind 'o'
set -g @sessionx-window-mode 'on'

# Other examples:
# set -g @plugin 'github_username/plugin_name'
# set -g @plugin 'github_username/plugin_name#branch'
# set -g @plugin 'git@github.com:user/plugin'
# set -g @plugin 'git@bitbucket.com:user/plugin'

# set -g @catppuccin_status_modules_right "... battery ..."
set -g @catppuccin_window_left_separator ""
set -g @catppuccin_window_right_separator " "
set -g @catppuccin_window_middle_separator " █"
set -g @catppuccin_window_number_position "right"

set -g @catppuccin_window_default_fill "number"
set -g @catppuccin_window_default_text "#W"

set -g @catppuccin_window_current_fill "number"
set -g @catppuccin_window_current_text "#W"

set -g @catppuccin_status_modules_right "session battery"
set -g @catppuccin_status_left_separator  " "
set -g @catppuccin_status_right_separator ""
set -g @catppuccin_status_right_separator_inverse "no"
set -g @catppuccin_status_fill "icon"
set -g @catppuccin_status_connect_separator "no"

set -g @catppuccin_directory_text "#{pane_current_path}"

# Initialize TMUX plugin manager (keep this line at the very bottom of tmux.conf)
run '~/.tmux/plugins/tpm/tpm'

I was confused as to why it worked now but it is working

b1tray3r commented 5 months ago

Well I am running this setup, where it is running now:

❯ tmux -V tmux 3.3a ❯ zoxide -V zoxide v0.4.3-unknown ❯ fzf --version 0.45.0 (202401011)

~/.config/tmux/tmux.conf

# [...] unrelated
set -g @sessionx-bind 'O'
set -g @sessionx-window-mode 'on'
# [...] unrelated

System information:

OS: Ubuntu 23.04 lunar Kernel: x86_64 Linux 6.2.0-39-generic Shell: zsh 5.9

omurilo commented 5 months ago

Damm, now Im stucked when press preffix + o, need open new terminal tab and close the actual.

the-spanish-guy commented 5 months ago

Damm, agora estou preso quando pressione preffix + o, precisa abrir nova guia terminal e fechar o real.

It happened to me too, did you do unbind-key o before set -g @sessionx-bind 'o' ?

b1tray3r commented 5 months ago

I rebound the key to set -g @sessionx-bind 'O', then it worked.

omerxx commented 5 months ago

Hi people, anyone still having issues and would like to share workflow / setup? Reply here / DM at https://t.me/omerxx

enthusiva commented 5 months ago

In my case, one of the prerequisites of this plugin, "fzf-tmux" script was not installed in my system. once I added it, I could see the pop-up.

https://github.com/junegunn/fzf/blob/master/bin/fzf-tmux

touchedthecode commented 5 months ago

I came here because of the same problem, on my Mac it worked fine, but on Windows 10 WSL2 Ubuntu it didn't work. I tried everything but nothing worked, until I randomly fixed it by switching from zsh to bash and back to zsh.

Maybe it was some kind of caching problem, although I restarted zsh multiple times and that didn't help. Weird.

Maybe this can help someone. :)

omerxx commented 5 months ago

Thanks @enthusiva I'll add this to the prerequisites!

@touchedthecode I don't do black magic haha

moritz157 commented 5 months ago

I have the same problem on PopOS with zsh.

I used exactly the same configuration @the-spanish-guy used, restarted tmux and even tried rebooting, but it didn't work. Tmux completely freezes, when I press the keybinding. However, I can close the terminal, open a new one, reattach to the previously frozen session and it unfreezes again. I also tried rebinding to a different key, but that didn't help either.

moritz157 commented 5 months ago

Update: I got it to work 🚀 Looks like there is a problem with tmux version 3.2a on certain Ubuntu releases as hinted at in this issue on the t-smart-tmux-session-manager project.

However, since 3.2a is the newest version installable through apt, I had to build tmux from source. I am now on tmux version 3.3a and everything works fine.

conghuynhho commented 5 months ago

Update all of these make it works for me: Tmux + FZF + Zoxide.

MoS2DL commented 4 months ago

I experienced the same issue here, no pop up showing. But managed to fix it.

I'm on Pop!_os and had the apt version of tmux installed, that is version 3.2a.

Seeing the last comments here I tried to uninstall tmux 3.2a and compiled version 3.4 from source instead. Now the popup works. So, it seems that tmux 3.2a has some kind of conflict at least.

Zananok commented 4 months ago

Same issue. Freezes on prefix + O. Restore access by closing Terminal/tab and reopening, as in previous reports.

# [...] unrelated
set -g @sessionx-bind 'O'
set -g @sessionx-window-mode 'on'
# [...] unrelated

Tried with standard latest debian packages, then manually updated/built everything and restarted with no success:

❯ zoxide -V
zoxide 0.9.4
❯ tmux -V
tmux next-3.5
❯ fzf --version
0.46.1 (3c0a630)
❯ fzf-tmux --version
fzf-tmux (with fzf 0.46.1 (3c0a630))
❯ bat --version
bat 0.24.0 (fc95468)
❯ zsh --version
zsh 5.9 (x86_64-pc-linux-gnu)
❯ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"

Windows 11 64x - WSL v1 - Debian 11 - Windows Terminal 1.19.10573.0

Extra info:

ProgmRuanSilva commented 4 months ago

Hey @Zananok

Did you test the default or another keys? Or change the @sessionx-bind to be another key?

Tanks to your contribution

Zananok commented 4 months ago

Hey, @ProgmRuanSilva tried with both o and O, and now, for a sanity check, with both u and r. Additionally, I removed any "@sessionx-bind", restarted the tmux server and attempted using the default O, however it seemed to just do a default tmux command of switching between panes. By default, I start tmux with -u, but I also killed the server and started it with no flags and attempted the same experiment as aforementioned.

All attempts resulted in the same outcome: gets frozen.

Thank you for your time

ProgmRuanSilva commented 4 months ago

understood @Zananok ,

let's try these options:

  1. Check if the tmux and fzf versions, and update it to the newest versions
  2. Might is the bind keys which is unreally in uses
    • unset all key using: unbind -a
    • see if it works
    • if not set the rebind keys.
Andreasgdp commented 4 months ago

For me tmux-sessionx would not appear at all if tmux was initially launched (i.e. no active sessions) as a command when opening a terminal e.g. terminator -e "tmux" or kitty sh -c "tmux"...

For me i solved it with adding the following to my .zshrc file. if [ "$TMUX" = "" ]; then tmux; fi

It seemed to also work with just starting tmux from a blank terminal using tmux if you don't want to have it launch every time.

System: Ubuntu 22.04 I also built tmux from source (v. 3.4) as well as fzf from source (0.48.1), so that can also have something to do with it. But just building from source did not fix. Only after also doing the above.

ewilazarus commented 3 months ago

Hey everybody!

In case you're autostarting tmux in your shell, make sure that you source the .fzf.zsh/.fzf.bash before you do so.

This is what was breaking my configuration! I hope this helps. :wave:

omerxx commented 2 months ago

Hello good people of this thread, just wondering whether anyone still experiencing issues with this. If not I'll give this issue a few more days before closing it.

Zananok commented 2 months ago

The issue is how the fzf args were handled. I did a quick fix locally, most of which was to wrap the args in quotes. But decided to go on to a custom solution.

I checked your sessionx.sh and now it seems that they were wrapped in ", so I decided to try it once more from main and it works for me.

omerxx commented 2 months ago

The issue is how the fzf args were handled. I did a quick fix locally, most of which was to wrap the args in quotes. But decided to go on to a custom solution.

I checked your sessionx.sh and now it seems that they were wrapped in ", so I decided to try it once more from main and it works for me.

Thank you!

omerxx commented 2 months ago

Please reopen if this is becomes relevant again

hesperaux commented 1 month ago

Hi all, I'm seeing this issue. If I watch very carefully and attempt to open it repeatedly, I can see a brief glimpse inside the popup with an error message saying something like "scrollbar display width should be 1" or something to that effect. It's so fast I can't capture it.

I'm running fzf 0.38.0 (debian), with tmux 3.3a. I'm on debian linux (bookworm 12.5) with alacritty 0.11.0.

Any suggestions?

Thanks! -David