omise / omise-python

Omise Python Library
https://docs.opn.ooo
MIT License
26 stars 15 forks source link

Allow access to metadata #53

Closed som-m closed 3 years ago

som-m commented 3 years ago

Summary

QA

You should be able to access metadata.

  1. Create a transfer with metadata.

    transfer = omise.Transfer.create(
    amount = 100000,
    metadata = dict(
        recipient_id = '0001',
        recipient_name = 'Somchai'
    )
    )
  2. Access metadata.

    >>> transfer.id
    'trsf_test_5n6maxqnnscx4046wqn'
    >>> transfer.metadata.recipient_name
    'Somchai'
nakarinh14 commented 2 years ago

@danfowler @rezigned

Hello Omise team, I know it has been a year since the last commit on this repo but can we at least get a minor official release that contains this fix?

The latest release 0.11.0 with pip install omise still got this breaking change, and needs to explicitly install the master branch for the fix.

General developers might not know about this and get confused, and I think it would be nice if the fix is present in the official release.

amborish-omise commented 2 years ago

Hello @nakarinh14 , thanks for the feedback, We are looking at this one and will release a fix soon.

danfowler commented 1 year ago

Hello @nakarinh14, sorry for the delay. We've released 0.12.0 that includes this change.