search

omise / omise-python

Omise Python Library
https://docs.opn.ooo
MIT License
26 stars 15 forks source link

Added kwargs to capture method #64

Closed yurasavin closed 1 year ago

yurasavin commented 1 year ago

Hi! It's not possible to perform partial capture with python SDK since capture method doesn't accept any params. This patch fix it

aashishgurung commented 1 year ago

@yurasavin We greatly appreciate your valuable contribution. Could you also incorporate some test cases? Our goal is to ensure that each change is thoroughly tested before merging.

yurasavin commented 1 year ago

@aashishgurung Here is it. Can you review my test please?

AnasNaouchi commented 1 year ago

@aashishgurung Here is it. Can you review my test please?

@yurasavin Thank you for providing some tests for your changes. As you can see the test is failing so it would be appreciated if you can please modify your test for it to pass.