search

onedesign / generator-one-base

A foundation for One Design Company projects on the web.
Other
1 stars 1 forks source link

Replaces childProcess in Craft3 generator #167

Open brianjhanson opened 6 years ago

brianjhanson commented 6 years ago

Closes #153.

I didn't replace the childProcess.execSync calls in the Craft 2 generator permission calls because 1) It make them more confusing rather than less so 2) this.spawnCommandSync is meant to normalize differences between OS, but chmod and find unix commands anyways.

cmalven commented 6 years ago

I don't have time right now to look into why this doesn't work, but it doesn't for me (using Laravel Valet).

If I run the generator before switching to this branch using My Project as the title, and then hit http://my-project.test/ the site works, but if I then switch to this branch, do the exact same thing, and hit the same URL, it doesn't work.

cmalven commented 6 years ago

Followup, thought the reason it might not be working was the change to "craftcms/cms": "^3.0.0" for the Craft version, but I applied that change to feature/base-generator-v2 and that worked fine, so that's not it.