onedesign / generator-one-base

A foundation for One Design Company projects on the web.
Other
1 stars 1 forks source link

Adds Craft Sub-Generator #42

Closed cmalven closed 7 years ago

cmalven commented 7 years ago

Closes #32

Adds a new sub-generator responsible for everything related to setting up Craft for a new project:

There is a lot going on here, so I'd appreciate anyone who can running this and seeing if there is anything missing.

mkornatz commented 7 years ago

This looks really good. I can't think of anything else to add at the moment. Great work!

brianjhanson commented 7 years ago

Just tried to run this and got:

Error: Cannot find module 'download'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/brianhanson/Development/generator-one-base/generators/craft/index.js:5:16)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

I think this is happening because it's trying to run the Craft generator before actually installing the modules.

EDIT: This might be my fault. Please hold.

cmalven commented 7 years ago

@brianjhanson make sure you run npm install && npm link in the generator-one-base directory before trying to run the generator.

brianjhanson commented 7 years ago

Yep, realized that shortly after posting.

brianjhanson commented 7 years ago

Seemed to work well.