search

onedesign / generator-one-base

A foundation for One Design Company projects on the web.
Other
1 stars 1 forks source link

Add dotenv to package.json #81

Closed molwells closed 7 years ago

molwells commented 7 years ago

Our gulp/config.js requires dotenv, but that package does not exist in our package.json

cmalven commented 7 years ago

@molwells This one should be pretty simple. Do you have any interest in tackling this?

It would be as simple as adding dotenv to the list here https://github.com/onedesign/generator-one-base/blob/master/generators/gulp/index.js#L43

molwells commented 7 years ago

@cmalven I do! I'll let you know if I have any questions.

cmalven commented 7 years ago

Great! Thanks @molwells!

cmalven commented 7 years ago

@molwells not sure how I didn't notice this earlier, but it does look like dotenv is getting installed and should be in the package.json (https://github.com/onedesign/generator-one-base/blob/master/generators/gulp/index.js#L53). And then I double-checked by running the generator and dotenv is indeed in my package.json. Can you make sure your generator is up-to-date and try again?

molwells commented 7 years ago

Ah @cmalven my bad. I didn't setup the project where I noticed this bug, and I had (wrongly) assumed the project was created using the latest version of the generator. Closing this issue.

cmalven commented 7 years ago

Phew! Thanks for double-checking @molwells