onelogin / terraform-provider-onelogin

GNU General Public License v3.0
27 stars 19 forks source link

[Feature Request] Ability to retrieve SAML Metadata from onelogin_apps #113

Closed chanceball closed 1 year ago

chanceball commented 1 year ago

Currently upgrading to version 0.3.9 In version 0.2.0, when onelogin SAML and OIDC apps had different resources, you could retrieve the metadata from the exported metadata_url of a onelogin_saml_app In the newer versions pushed recently, which combined the apps intoonelogin_apps, there is no Terraform based way to retrieve the metadata (At least that I can see in the docs).

Jmfwolf commented 1 year ago

Thank you for opening the ticket, I will prioritize the SAML app feature fixes. Normally with the metadata_url is returned within the SSO object of the SAML app when it is handled through the API. Was this the same behavior with the previous provider implementation you are refering to?

In our attempts to create a polymorphic interface for apps in the Terraform provider, the two striking differences between the implementations are the SSO and the Configuration objects within the app object. The challenge has been how to handle the more freeform objects within Golang.

Jmfwolf commented 1 year ago

@chanceball v0.4.0 is released. The SSO object of the app has been added, which should alleviate the issue

chanceball commented 1 year ago

That was exactly what I was looking for, thank you so much for your quick turnaround!