onelogin / terraform-provider-onelogin

GNU General Public License v3.0
27 stars 19 forks source link

Modify type of role #32

Closed at-k closed 3 years ago

at-k commented 3 years ago

Problem

terraform plan detects differences on the list just showing item order, which makes no effect actually.

Example

  # module.developer.onelogin_roles.role will be updated in-place
  ~ resource "onelogin_roles" "role" {
      ~ admins = [
          - 34873631,
            34873695,
          + 34873631,
        ]
        apps   = [
            698140,

Solution

According to official reference, schema.TypeList represents an ordered collection of items.

On the other hand, TypeSet is for used to represent an unordered collection of items,. It seems better for Role.

Is there any problem to change types of them?

dcaponi commented 3 years ago

Hey @at-k Thank you for the tip! I see the tests passing. Im going to merge this and release a new version. Thanks again 😄

Your changes will be in release v0.1.3