search

onelogin / terraform-provider-onelogin

GNU General Public License v3.0
27 stars 19 forks source link

Missing brand_id on App resource #34

Closed richet closed 3 years ago

richet commented 3 years ago

The OneLogin App resource now supports a brand_id attribute that can be used to control the branding of the login page for the app.

https://developers.onelogin.com/api-docs/2/apps/app-resource

Can we get this added to the App resource in the provider?

dcaponi commented 3 years ago

According to that documentation, it looks like one should be able to set it and its optional. I'll add that 👍

Here's the PR for this

richet commented 3 years ago

Yes the default is null and it can be set on create or update.

Awesome. Thanks!

dcaponi commented 3 years ago

Should be good to go as of v0.1.5