search

onelogin / terraform-provider-onelogin

GNU General Public License v3.0
27 stars 19 forks source link

OIDC App Missing post_logout_redirect_uri #50

Closed akozmic-prisidio closed 3 years ago

akozmic-prisidio commented 3 years ago

looks like there is no option for post_logout_redirect_uri on the OIDC App https://github.com/onelogin/terraform-provider-onelogin/blob/develop/docs/resources/onelogin_oidc_app.md

This caused me to accidentally blow away all our values on a dev server today. I noticed the OneLogin SDK for Go also doesn't support it yet so the SDK would likely need to be updated as well. https://github.com/onelogin/onelogin-go-sdk/blob/develop/pkg/services/apps/model.go#L61

dcaponi commented 3 years ago

@akozmic-prisidio I added this in v0.1.16 which should be available today. please re-open the issue if there is a probelm.

akozmic-prisidio commented 3 years ago

Thanks @dcaponi it looks like its there. Is there a reason it's not in the "configuration" section? Looks like its in "parameters" see: https://github.com/onelogin/terraform-provider-onelogin/blob/develop/docs/resources/onelogin_oidc_app.md.

I see further down in documentation that it says it's in "configuration". Not sure if this is an issue with the code or just an issue with the documentation readme.

dcaponi commented 3 years ago

oh this is my bad. looks like the example is wrong. It should be in the configuration section and it is correctly placed in the resource https://github.com/onelogin/terraform-provider-onelogin/blob/develop/ol_schema/app/configuration/configuration.go#L55 and https://github.com/onelogin/terraform-provider-onelogin/blob/develop/ol_schema/app/configuration/configuration.go#L123

functionally this should be usable with a hotfix coming up soon v0.1.17