search

onflow / flow-go-sdk

Tools for building Go applications on Flow :ocean:
https://onflow.org
Apache License 2.0
212 stars 86 forks source link

Add SubscribeBlockHeaders* endpoints #760

Closed illia-malachyn closed 1 month ago

illia-malachyn commented 2 months ago

Part of #746

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 69.62025% with 24 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (7b58582) to head (23fdfe2). Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/grpc.go 75.34% 11 Missing and 7 partials :warning:
access/grpc/client.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #760 +/- ## ========================================== + Coverage 52.92% 54.83% +1.91% ========================================== Files 35 35 Lines 5580 5788 +208 ========================================== + Hits 2953 3174 +221 + Misses 2231 2165 -66 - Partials 396 449 +53 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-go-sdk/pull/760/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-go-sdk/pull/760/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `54.83% <69.62%> (+1.91%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

peterargue commented 1 month ago

@illia-malachyn please fix the conflicts, then this is ready to merge