search

onflow / flow-go-sdk

Tools for building Go applications on Flow :ocean:
https://onflow.org
Apache License 2.0
212 stars 86 forks source link

TransactionResult type differs from protobuf schema #769

Closed illia-malachyn closed 1 month ago

illia-malachyn commented 2 months ago

This is part of #736

TransactionResult type on the SDK side https://github.com/onflow/flow-go-sdk/blob/master/transaction.go#L620

TransactionResultResponse message in the Protobuf schema https://github.com/onflow/flow/blob/master/protobuf/flow/access/access.proto#L416

computation_usage field is missing

peterargue commented 1 month ago

https://github.com/onflow/flow/blob/4998e288f99e963c2e6aa2474bf93c93e228a21b/protobuf/flow/access/access.proto#L416-L427

vs

https://github.com/onflow/flow-go-sdk/blob/2689460173c00977a27b99d5a57933d260990fb1/transaction.go#L620-L628

The main difference is the SDK is missing these fields: metadata, computation_usage.

Let's go ahead and add them.

status_code can be ignored.