onflow / flow-go-sdk

Tools for building Go applications on Flow :ocean:
https://onflow.org
Apache License 2.0
212 stars 86 forks source link

Make sure we use GetTransactionRequest properly #771

Closed illia-malachyn closed 1 month ago

illia-malachyn commented 2 months ago

This is a part of #736

GetTransactionRequest protobuf message was updated with new fields https://github.com/onflow/flow/blob/master/protobuf/flow/access/access.proto#L374

We don't use them on the SDK side https://github.com/onflow/flow-go-sdk/blob/master/access/grpc/grpc.go#L348

peterargue commented 1 month ago

We're going to skip this work for now since ti will require a breaking change to the API and have not received any requests to add it