Support get/delete file in Dataprep Microservice

opea-project / GenAIComps

GenAI components at micro-service level; GenAI service composer to create mega-service

Apache License 2.0

22 stars 54 forks source link

Support get/delete file in Dataprep Microservice #254

Closed letonghan closed 1 day ago

letonghan commented 1 week ago

Description

Support get_file(link) and delete_file(link) in Dataprep Microservice

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies

None

Tests

Local tested with Python and Docker.

letonghan commented 1 week ago

@xuechendi can you help to check the e2e test of dataprep/redis/langchain_ray? Seems like your test script has a different way from other scripts, could you modify it with bash instead of python?

xuechendi commented 1 week ago

@xuechendi can you help to check the e2e test of dataprep/redis/langchain_ray? Seems like your test script has a different way from other scripts, could you modify it with bash instead of python?

Hi, @letonghan , may I know what's the goal of this update. For ray testing, I'll send a batched request with a list of 20 texts. Using curl may make the codes look bad. Would like to understand the context so I can make it work.

xuechendi commented 1 week ago

@letonghan , I added a new commit to this PR for langchai_ray https://github.com/opea-project/GenAIComps/pull/254/commits/142622e308b271f4961bfc97aceb9b30f6fa7439

lvliang-intel commented 4 days ago

@letonghan please check this pre-commit issue.