search

opea-project / GenAIComps

GenAI components at micro-service level; GenAI service composer to create mega-service
Apache License 2.0
74 stars 136 forks source link

Docker image build fails for embeddings component #325

Open tonym97 opened 4 months ago

tonym97 commented 4 months ago

FYI maybe langchain updated their base image:

https://github.com/opea-project/GenAIComps/blob/main/comps/embeddings/langchain/docker/Dockerfile

1 warning found (use --debug to expand):

tonym97 commented 4 months ago

Double checked, yep it’s the base image. I see we are pulling the tag :latest. We should probably pin it to a good known version as is typical best practices for repos you don’t own…

BTW I can put up a proposed PR if you want for this, but happy to let you do it too as it’s a simple fix and I’m not sure if you want to make the fix a pinned tag or just checking the PYTHONPATH var or removing the $PYTHONPATH in the environment set command…

Just let me know the best way to help you guys.

preethivenkatesh commented 3 months ago

@tonym97 If you are referring to this line in the dockerfile ENV PYTHONPATH=$PYTHONPATH:/home/user This is a valid bash command that will go through in the docker build process. The message here is a warning but not necessarily an error. Please try again and if you finding the docker build to fail, attach the logs to this ticket

xiguiw commented 1 week ago

@tonym97 I cannot reproduce this problem on latest code. Could please help to confirm this at your side? We'll close this if you cannot reproduce it.

NOTE: Please ignore this warning. UndefinedVar: Usage of undefined variable '$PYTHONPATH' (line 26)