opea-project / GenAIComps

GenAI components at micro-service level; GenAI service composer to create mega-service
Apache License 2.0
44 stars 99 forks source link

[Bug] The vector store components are labelled as "langchain" #518

Open logan-markewich opened 3 weeks ago

logan-markewich commented 3 weeks ago

All the vector store components are labelled as langchain, but they don't use langchain at all, and instead setup the vector store infra themselves (i.e. qdrant containers, milvus containers, etc.)

This should probably be renamed/removed

devpramod commented 2 weeks ago

Hi @logan-markewich Though langchain is not being used while initializing the vector database, it is being used when we consume the vector db through the retriever for example, in the case of milvus you'll see from langchain_milvus.vectorstores import Milvus

logan-markewich commented 2 weeks ago

But couldn't any library be used to consume the vector db? llamaindex, haystack, etc.

The code in the vector_stores folder is just launching the DB itself, I don't think this is specific to any framework using it right?

devpramod commented 2 weeks ago

@kevinintel could you please comment on this implementation choice

kevinintel commented 1 week ago

We are aware of this and will be refining the folder structure accordingly